ETHZ-TEC / RocketLogger

Official development repository of the RocketLogger project.
https://github.com/ETHZ-TEC/RocketLogger/wiki
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Remove debug console output in Python data processing library functionality #46

Closed rtrueb closed 2 years ago

rtrueb commented 2 years ago

It would be helpful if the printout of the merge_channels function could be disabled (either permanently, via state of the RocketLoggerData class, or via a function argument).

lsigrist commented 2 years ago

Thanks @rtrueb, this is a very good point. It is probably not the task of a data processing library to print to the console what it is doing. I'd even extend your input to any print statement in rocketlogger.data (see list below) and rather make sure that relevant warnings/errors are raised for unexpected behavior/failures. What do you think? Does this match your reasons for raising this issue?

rtrueb commented 2 years ago

The proposed changes address my issue and make sense from my point of view.

lsigrist commented 2 years ago

fix verified using a942b32