Code change causes warning with armcc compiler

[CurtisAMU]

https://github.com/ETLCPP/etl/blob/b38afd7fc98f50a00b207b184506049f05ab7120/include/etl/private/vector_base.h#L171

The extra semicolon causes a warning if ETL_DEBUG_COUNT is not defined:

..\..\..\Lib\ETL\include\etl/private/vector_base.h(171): warning:  #381-D: extra ";" ignored
      ETL_DECLARE_DEBUG_COUNT;   ///< Internal debugging.

We have a zero warning policy for our project, which treats this as an error. It would be okay for debugging to have a warning to ignore but preferably not on release builds.

[jwellbelove]

Does it warn with void;

[jwellbelove]

Forget that last suggestion

[jwellbelove]

What about void(0);

[CurtisAMU]

ETL_DECLARE_DEBUG_COUNT; is a declaration and (void)0; does not work there; it's an expression. The former ETL_DECLARE_DEBUG_COUNT ///< Internal debugging. without the semicolon worked. What was the problem with that? It looks odd without the semicolon but should work.

This also works with armcc: #define ETL_DECLARE_DEBUG_COUNT struct SDebugCountDummy {}

[CurtisAMU]

A dummy typedef would also do.

[jwellbelove]

I added the semicolons as my IDE would not format following statements correctly without them. Everything would be indented.

[jwellbelove]

There will also be this warning if ETL_NO_CHECKS is defined for ETL_ASSERT etc.

[jwellbelove]

Do the other macros cause a warning? ETL_INCREMENT_DEBUG_COUNT etc

[CurtisAMU]

There will also be this warning if ETL_NO_CHECKS is defined for ETL_ASSERT etc.

Actually no. Empty statements are okay, it seems.

[CurtisAMU]

Do the other macros cause a warning? ETL_INCREMENT_DEBUG_COUNT etc

Not as far as I can see.

[CurtisAMU]

They are not used in a class declaration.

[jwellbelove]

If I try an empty statement in a Keil project using ARM compiler V6 I get

warning: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]

[CurtisAMU]

One of those complementary differences between compiler V5 and V6. There, (void)0; would help in both cases, I'd expect.

[jwellbelove]

Can you try this for me? (It says it accepts zip files, but it doesn't) debug_count.h.txt

[jwellbelove]

Ignore that file, there's an error.

[jwellbelove]

Can you try this patch? 749-9465468-Removed semicolon warnings.patch

[CurtisAMU]

Looks good, the warning is gone.

[jwellbelove]

Fixed 20.38.1