ETLCPP / etl

Embedded Template Library
https://www.etlcpp.com
MIT License
2.05k stars 373 forks source link

Move assignment not working for non-empty containers #758

Closed somaveszelovszki closed 9 months ago

somaveszelovszki commented 9 months ago

The move assignment is not working properly for some container types if the target is not empty. Affected container types: priority_queue, set, multiset. Solution: clear() needs to be called in these move assignment functions before adding the new elements to the target container. I already have the fix locally, but I don't have permission to push my branch and create a PR.

jwellbelove commented 9 months ago

I think you have to fork the project to do a PR.

somaveszelovszki commented 9 months ago

Thank you, I forked the project and created a PR.

jwellbelove commented 9 months ago

Fixed 20.38.2