search

ETLCPP / etl

Embedded Template Library
https://www.etlcpp.com
MIT License
2.05k stars 373 forks source link

Cannot insert existing value to full set #783

Closed ismailtzn closed 7 months ago

ismailtzn commented 8 months ago

When I try to insert a value to full set, it always throws set_full error, even if the value was already in the set.

jwellbelove commented 8 months ago

This may also be an issue for etl::flat_set and etl::unordered_set.

ismailtzn commented 8 months ago

You are right, I will look them too 😄

ismailtzn commented 8 months ago

I checked etl::reference_flat_set, etl::flat_set and etl::unordered_set, this issue does not occur for etl::reference_flat_set and etl::flat_set. For those two I added tests. I tried to fix etl::unordered_set also.

By the way, I couldn't see any contribution instructions, so I created a pull request directly. If you follow a particular way of accepting contributions, I'd love to do it your way.

jwellbelove commented 7 months ago

Fixed 20.38.7