Closed tigran2008 closed 2 weeks ago
Did you add a unit test?
Sorry, I overlooked that part :/
I'm away from my computer right now, but would the following be enough if I added it later?
Given this function:
template <typename T>
T add(T first, typename etl::type_identity<T>::type second) {
return first + second;
}
The result of add(2.5, 1)
would be checked if it was equal to 3.5
That looks OK.
Did I do this right? 😅
Well, I changed the CHECK into a CHECK_CLOSE.
Review changes with SemanticDiff.