search

ETLCPP / etl

Embedded Template Library
https://www.etlcpp.com
MIT License
2.25k stars 392 forks source link

ETL_USING_LEGACY_VARIANT Is always getting evaluated to 1 #937

Closed drewr95 closed 3 months ago

drewr95 commented 3 months ago

It seems that ETL_USING_LEGACY_VARIANT is always getting evaluated to 1 for me. I do not have ETL_USE_LEGACY_VARIANT defined, so the !ETL_USING_CPP11 must be getting evaluated to true. I believe this is because these macros are defined before determining compiler versions.   image

drewr95 commented 3 months ago

Looks like VSCode is confirming this: image

If we don't determine compiler version til line 153 (profiles/determine_compiler_version.h), how can ETL_USING_CPP11 be evaluated?

drewr95 commented 3 months ago

Yeah, can confirm, if I move that macro below determining compiler version my builds work again

jwellbelove commented 3 months ago

Fixed 20.39.3