ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

ADD: NEW B2MML-ErrorMessage.XSD #1

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

ERDi, MESA:
Background B2MML does not have an error handling schema. A basic set of error handling logic should be considered by MESA as starting point for users.

Solution ADD: B2MML-ErrorMessage.XSD This is an extension schema to help standardize the error handling logic.

gerardmoloneyetpartners commented 4 years ago

Grammar mistake with XML tag naming. ThrowedFrom should be ThrownFrom in ErrorInfo-UserArea.xsd Fixed in ETP Bitbucket

gerardmoloneyetpartners commented 4 years ago

@CharlieG021163 This is an ErrorHandling.xsd created by Rachel. Shall we propose this Error.xsd as a new B2MML-Error.xsd for inclusion in the MESA schemas? If yes, then we should change the name of this issue to: ADD: B2MML-ERROR.XSD I can then supply you with the .xsd and it already has the fix applied.

If not, then we can make this an ERDi Design Rule (i've created a milestone for ERDi Design Rule)

gerardmoloneyetpartners commented 4 years ago

Add File: ErrorInfo-UserArea.xsd

File xml

<?xml version="1.0" encoding="UTF-8" ?> <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" targetNamespace="http://www.mesa.org/xml/B2MML-Extention" xmlns:ext="http://www.mesa.org/xml/B2MML-Extention">

<xs:element name="ErrorMessage" type="ext:ErrorMessageType"  />

<xs:simpleType name="ErrorTypeType" final="restriction">
    <xs:restriction base="xs:string">
        <xs:enumeration value="BusinessError" />
        <xs:enumeration value="SystemError" />
    </xs:restriction>
</xs:simpleType>

<xs:complexType name="ErrorMessageType">
    <xs:sequence>
        <xs:element name="ThrownFrom" type="xs:string" />
        <xs:element name="TimeStamp" type="xs:dateTime"/>
        <xs:element name="ErrorType" type="ext:ErrorTypeType"/>
        <xs:element name="ErrorCode" type="xs:string" minOccurs = "0" />
        <xs:element name="ErrorDescription" type="xs:string" minOccurs = "0" />
        <xs:element name="CausedBy" type="ext:ErrorMessageType" minOccurs = "0" />
    </xs:sequence>
</xs:complexType>

</xs:schema>

CharlieG021163 commented 4 years ago

Trapper will send actual file. Charlie will review.

gerardmoloneyetpartners commented 4 years ago

Charlie, try this link Process Event Wrappers/ErrorInfo-UserArea.xsd https://github.com/etpartners-com-au/ETPSchemaDesign/blob/master/Process%20Event%20Wrappers/ErrorInfo-UserArea.xsd

Dennis-Brandl commented 4 years ago

I think a brief discussion with the ISA 95 committee is needed here. I agree with the need, but they may have more ideas on the error types. In addition the ErrorTypeType needs to have an "Other" category to allow for extensions.

gerardmoloneyetpartners commented 4 years ago

More than happy to add an 'other' element. Does this really need to go to ISA95 @Dennis-Brandl ? I would see this simply as a tool of xml to handle business errors outside of ISA95 concepts, without breaking the xml formatting of the message. This way, incorrect values can be directly fixed, and the message replayed without having to convert a non-B@MML error message.

If we do have to take it to ISA95, can we arrange a meeting to discuss with them next week?

Dennis-Brandl commented 4 years ago

After discussion, and no objections from the ISA 95 committee, I added this to the MESA V0700 that I just uploaded. This issue can be closed.

gerardmoloneyetpartners commented 4 years ago

@Dennis-Brandl did you also add an 'other' element on your change?

Dennis-Brandl commented 4 years ago

Gerard,

Yes it includes the “other” element I the error type:

Dennis Brandl 208 Townsend Ct, Suite 200 Cary, NC 27518-8319, USA +1-919-852-5322 (Office) +1-919-656-2205 (Cell) +1-832-201-0554 (Fax) www.brlconsulting.com DnBrandl@BRLConsulting.com From: gerardmoloneyetpartners Sent: Monday, August 31, 2020 7:48 AM To: ETPartners/b2mmlv7beta Cc: Dennis Brandl ; Mention Subject: Re: [ETPartners/b2mmlv7beta] ADD: NEW B2MML-ErrorMessage.XSD (#1) @Dennis-Brandl did you also add an 'other' element on your change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or unsubscribe .