ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Change xxxTestSpecification element to TestSpecification in all Resource.xsds, their xxxInformationType, and entity types to align with updated 950002 #10

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

This issue and solution are the complete explanation and solution across all types which include closed issues #13, #14, and #15.

Background In B2MML, all instances of the XXXTestSpecificationID element should be changed to TestSpecificationID to align with updated 950002 Operations Test Model. Also, general use of TestSpecificationID aligns with the existing OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinitionType. MESA may not do this solution. ERDi should.

Impacted Types and Solutions

  1. The following Impacted Types and Changed Elements in the resource schema changed to TestSpecification and TestSpecificationID element: Element in each Type: Material.xsd

    • "MaterialInformationType": CHANGE "MaterialCapabilityTestSpecification" TO "TestSpecification"
    • "MaterialClassType": CHANGE "MaterialTestSpecificationID" TO "TestSpecificationID"
    • "MaterialDefinitionType": CHANGE "MaterialTestSpecificationID" TO "TestSpecificationID"
    • "MaterialLotType": CHANGE "MaterialTestSpecificationID" TO "TestSpecificationID"
    • "MaterialSublotType": ADD "TestSpecificationID" Equipment.xsd
    • "EquipmentInformationType": CHANGE "EquipmentCapabilityTestSpecification" TO "TestSpecification"
    • "EquipmentClassType": CHANGE "EquipmentCapabilityTestSpecification" TO "TestSpecificationID"
    • "EquipmentType": CHANGE "EquipmentCapabilityTestSpecification" TO "TestSpecificationID" PhysicalAsset.xsd
    • "PhysicalAssetInformationType": CHANGE "PhysicalAssetCapabilityTestSpecification" TO "TestSpecification"
    • "PhysicalAssetClassType": CHANGE "PhysicalAssetCapabilityTestSpecification" TO "TestSpecificationID"
    • "PhysicalAssetType": CHANGE "PhysicalAssetCapabilityTestSpecification" TO "TestSpecificationID" Personnel.xsd
    • "PersonnelInformationType": CHANGE "Qualification TestSpecification" TO "TestSpecification"
    • "PersonnelClassType": CHANGE "QualificationTestSpecification" TO "TestSpecificationID"
    • "PersonType": CHANGE "QualificationTestSpecification" TO "TestSpecificationID" DONE: Above Edits complete
  2. Extensions.xsd DELETE the following xsd:group name:

    • MaterialCapabilityTestSpecification
    • MaterialTestSpecification
    • EquipmentCapabilityTestSpecification
    • PhysicalAssetCapabilityTestSpecification
    • QualificationTestSpecification

Supporting Documents 950002 JWG5 CDV01 version (2019 12) Clause 5.4.2 Personnel class, Table 30 – Personnel class relationship roles Clause 5.4.4 Person, Table 34 – Person relationship roles Clause 5.5.2 Equipment class, Table 39 – Equipment class relationship roles Clause 5.5.4 Equipment, Table 43 – Equipment relationship roles Clause 5.6.2 Physical asset class, Table 49 – Physical asset class relationship roles Clause 5.6.4 Physical asset, Table 53 – Physical asset relationship roles Clause 5.7.2 Material class, Table 60 – Material class relationship roles Clause 5.7.4 Material definition, Table 64 – Material definition relationship roles Clause 5.7.6 Material lot, Table 68 – Material lot relationship roles Clause 5.7.8 Material sublot, Table 72 – Material sublot relationship roles Clause 5.7.8 Material sublot, Table 72 – Material sublot relationship roles Clause 5.9.3 Testable object and testable object property, Table 100 Instances of testable object

racheliurui commented 5 years ago

https://github.com/ETPartners/ISA-950002/blob/master/05_Common%20object%20models.md Table 59 – Material model relationships The simplified model don't have "Material Test Specification " teminology at all.

racheliurui commented 5 years ago

Agreed. Test specification itself defines all the information regarding the specific test, and one test spec might be applicable to multiple different categories of testable objects.

Dennis-Brandl commented 4 years ago

I agree with the change.