ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

TestSpecificationID instead of xxxxTestSpecificationID should be included in testable object definition #13

Closed racheliurui closed 5 years ago

racheliurui commented 5 years ago

Refer to #10 where this issue and solution are part of the complete explanation and solution across all types. Duplicate with closed #14 and #15.

Background In the B2MML, all instances of the XXXTestSpecificationID element should be changed to TestSpecificationID to align with updated 950002 Operations Test Model.
Also general use of TestSpecificationID aligns with the existing OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinitionType. MESA may not do this solution. ERDi should.

Impacted Types and Solution ERDi, MESA: MaterialClassType: CHANGE: MaterialTestSpecificationID element TO: TestSpecificationID

The following Types shall be changed similiarly:

racheliurui commented 5 years ago

Agreed. In the real case, test specification ID itself implies the ID can be used to find all the information regarding the specific test. With the element name try to declare where the sample comes from, will make things complicated. A simplified tag would support using standard test specification model.

racheliurui commented 5 years ago

@CharlieG021163 may I suggest you please direct comment instead of editing initial comment of the issue unless the issue itself is opened by you. That way, it's easier for me to read your feedback instead of checking the change of the initial comment.

racheliurui commented 5 years ago

As recommended by @CharlieG021163 , this change is duplicated with #10

The description of #10 will be updated to cover the change and this one will be labelled as duplicated and closed.