ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Change TestPropertyMeasurementType to PropertyMeasurementType in Common.xsd (if OperationsTest.xsd not used) to align with updated 950002 Operations Test #17

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background and Solution ERDi, MESA: Related to #101 To align with updated 950002 Operations Test Model's relationships. Align TestResult element with updated 950002, Operations Test Model where the Test Result object has an association relationships with the resource actual objects. Under issue #101, the new OperationsTest.xsd schema is added to align with 950002 by including TestSpecificationType and TestResultType together which allows 1st order transactions for both types.

Solution IF MESA does not except this change, the following change is recommended to Common.xsd. CHANGE: "TestPropertyMeasurementType" with "PropertyMeasurementType"

Impacted Types Common.xsd TestPropertyMeasurementType

Supporting Document 950002 JWG5 CDV01 version (2019 12) Clause 5.9.9, Property measurement, Table 114 Property measurement attributes.

racheliurui commented 5 years ago

ISA-950002 Section 5.9.9 Table 114 Property measurement attributes

racheliurui commented 5 years ago

@CharlieG021163 the latest version at draft branch have a typo problem (missing "minOccurs = "0" nillable="true"/>") at line 1540, could you please fix it? or do you want me to fix it?

https://github.com/ETPartners/b2mmlv7beta/blob/2d1c9e261f24c4cb75ea5afa71f9f64c35081b88/Schema/B2MML-Common.xsd#L1540

racheliurui commented 5 years ago

@CharlieG021163 If you change the name from "TestPropertyMeasurementType" to "PropertyMeasurement", should you also change the last element for PropertyMeasurement to something like,

<xsd:group   ref  = "Extended:PropertyMeasurement" minOccurs="0" maxOccurs="1"/> 

and also change the https://github.com/ETPartners/b2mmlv7beta/blob/2d1c9e261f24c4cb75ea5afa71f9f64c35081b88/Schema/B2MML-CommonExtensions.xsd#L236 to

    <xsd:group name = "PropertyMeasurement">
CharlieG021163 commented 5 years ago

Yes, WIP. Thanks.

racheliurui commented 5 years ago

Agreed

Dennis-Brandl commented 4 years ago

I agree with the change.