ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

In Common.xsd, Change EquipmentElementLevelType, EquipmentElementLevel1Type, LocationType, and HierarchyScopeType to align with updated 950002 #18

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background MESA may not make this change. ERDi should. Align BatchML-BatchInformation.xsd with B2MML-Common.xsd:

  1. BatchInformation.xsd has the EquipmentElementLevel element to the EquipmentElementLevelType compared to Common.xsd which as the EquipmentLevel element to the EquipmentLevelType.
  2. ISA-88 has the Equipment Element Level attribute compared to ISA-95's Equipment Level attribute. The two attributes represent same defined values and definitions; And so should use the same type in Common.xsd.
  3. To support the ISA-88 and ISA-95 attributes as the same definition, the following change was made to align with BatchML to B2MML's Common.xsd.

Impacted Types and Solutions To align with updated ISA950002 and ISA880002, Change the following,

  1. Common.xsd, complexType name="HierarchyScopeType"_ CHANGE:
                <xsd:element name="EquipmentLevel" type="EquipmentElementLevelType"/>
            <xsd:choice>

    TO:

               <xsd:element name="EquipmentLevel" type="EquipmentLevelType"/>
           <xsd:choice>
  2. Common.xsd, complexType name="EquipmentElementLevelType"_ CHANGE: complexType name="EquipmentElementLevelType TO: complexType name="EquipmentLevelType CHANGE: TO:
  3. Common.xsd, name="EquipmentElementLevel1Type"_ CHANGE: complexType name="EquipmentElementLevel1Type"
    TO: complexType name="EquipmentLevel1Type
  4. Common.xsd, complexType name="LocationType"_ CHANGE: element name="EquipmentElementLevel" type="EquipmentLevelType" TO:
            <xsd:element name="EquipmentLevel" type="EquipmentLevelType"/>
  5. BatchInformation.xsd, complexType name = "EquipmentElementType" CHANGE: element name = "EquipmentElementLevel" type = "EquipmentElementLevelType" TO: element name = "EquipmentElementLevel" type = "EquipmentLevelType"
  6. BatchInformation.xsd, in the section: -- Commonly used elements -- CHANGE: element name = "EquipmentElementLevel" type = "EquipmentElementLevelType" TO: element name = "EquipmentElementLevel" type = "EquipmentLevelType"
racheliurui commented 5 years ago

The naming showing in XML payload will always be "EquipmentLevel", so the backend element naming with or without "Element" doesn't matter that much.

Thus I support this change if it will make the XSD better aligned with Standard.

CharlieG021163 commented 5 years ago

Rachel, do know if your statement above is true in JSON or Protobuf

racheliurui commented 5 years ago

Rachel, do know if your statement above is true in JSON or Protobuf

Hi, Charlie, I reckon it's the same with JSON or Protobuf, as, in payload, we never see a tag name has "1" in it. And when we do the transformation to photo buff schema, I have to transform those definition with name contain "1" as the tool won't support definition with that complexity.

gerardmoloneyetpartners commented 4 years ago

Agreed again.

CharlieG021163 commented 4 years ago

Align BatchML-BatchInformation.xsd with B2MML-Common.xsd:
EquipmentElementType in BatchInformation.xsd has the EquipmentElementLevel element for EquipmentLevelType in Common.xsd since ISA-88 uses Equipment Element Level as an attribute compare to the Equipment Level attribute in ISA-95. The two attributes represent the same equipment level defined values and definitions; And so should use the same type in Common.xsd. The support the ISA-88 and ISA-95 elements the following change was made and recorded in original comment above.

ERDi, MESA: complexType name="HierarchyScopeType", CHANGE: TO: xsd:choice>

               <xsd:element name="EquipmentLevel" type="EquipmentLevelType"/>
xsd:choice>               
Dennis-Brandl commented 4 years ago

I agree to the change.