ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Remove EvaluatedPropertyReference from xxxPropertyType to align with updated 950002 Operations Test Model #21

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background ERDi, MESA: Refers to #49, #95, #101 In the updated 950002 Operations Test Model, the relationship source role name is not a required element for the "Corresponds to" unidirectional relationship from the Evaluated Property object (source) (under the Test Specification object) to the xxxProperty object (target, Testable Object Property). There is No reference attribute. In B2MML, the EvaluatedPropertyReference element is not necessary and creates a circular reference since the Testable Object Property has a composite relationship to the Testable object which has the "specifies" relationship to associated TestSpecification element. The TestSpecifictionID identifies the defined the EvaluateProperty(s) by it composite relationship.

Supporting Document 950002 JWG5 CDV01 version (2019 12) Clause 5.5.3 Equipment class property, Table 41 – Equipment class property relationship roles Clause 5.5.5 Equipment property, Table 45 – Equipment property relationships Clause 5.6.3 Physical asset class property, Table 51 – Physical asset class property relationship roles Clause 5.6.5 Physical asset property. Table 55 – Physical asset property relationship roles Clause 5.7.3 Material class property, Table 62 – Material class property relationship roles Clause 5.7.5 Material definition property, Table 66 – Material definition property relationship roles Clause 5.7.7 Material lot property, Table 70 – Material lot property relationship roles Clause 5.9.1 Operations test model, Figure 16- Operations test model Clause 5.9.7 Evaluated property, Table 109 – Evaluated property relationship roles Clause 5.11.3 Operations event class property, Table 128 – Operations event class property relationship roles 950004 JWG5 CDV01 version (2019 12) Clause 6.16.3 Workflow specification property, Table 33 – Workflow specification property relationship roles

Impacted Types and Solution From the following types: DELETE:

  1. B2MML - Equipment.xsd -EquipmentPropertyType -EquipmentClassPropertyType
  2. B2MML - Material.xsd -MaterialClassPropertyType -MaterialDefinitionPropertyType -MaterialLotPropertyType
  3. B2MML-PhysicalAsset.xsd -PhysicalAssetClassPropertyType -PhysicalAssetPropertyType
  4. B2MML-Personnel.xsd -PersonnelClassPropertyType -PersonPropertyType
  5. B2MML-OperationsEvent.xsd -OperationsEventClassPropertyType
  6. B2MML-WorkflowSpecification.xsd -WorkflowPropertyType, #49 DELETED WorkflowPropertyType which DELETED EvaluatedPropertyReference element.
racheliurui commented 5 years ago

Supporting Document in ISA-950002

Section 5.9.1 Figure 16- Operations test model Table xx - xxx property relationship roles (for example, Table 41 – Equipment class property relationship roles)

CharlieG021163 commented 5 years ago

The initial comment was updated with more impacted types and updated explanation.

Dennis-Brandl commented 4 years ago

I agree with the change.