search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update TestSpecificationType elements in TestSpecification.xsd (if OperationsTest.xsd is not used) to align with updated 950002 #24

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

https://github.com/MESAInternational/B2MML-BatchML/issues/47

Background, Related to #101

Under issue #101, the new OperationsTest.xsd schema is added to align with 950002 by including TestSpecificationType and TestResultType together which allows 1st order transactions for both types.

Solution IF MESA does not except the OperationsTest.xsd change, the following changes are recommended to TestSpecification.xsd.

CHANGE: "TestPropertyMeasurementType" with "PropertyMeasurementType" Multiple changes to TestSpecificationType to align with updated 950002 Operations Test Model's Test Specification object.

complexType name = "TestSpecificationType" element name = "EvaluatedProperty", CHANGE: type = "TestSpecificationEvaluatedPropertyType" to "EvaluatedPropertyType"

complexType name = "TestSpecificationType" CHANGE: element name = "PhysicalSample" TO: "PhysicalSampleRequired"

complexType name = "TestSpecificationType", ADD: element name = "OperationsTestRequirementID"

complexType name = "TestSpecificationType", ADD: element name = "TestableObjectID"

Supporting Document

950002 JWG5 CDV01 version (2019 12) Clause 5.9.7 Evaluated property Clause 5.9.4 Test specification, Table 103 – Test specification relationship roles

Impacted Types

B2MML-TestSpecification.xsd

racheliurui commented 5 years ago

Personal opinion, The original name "PhysicalSampleRequired" is very natural to think the possible value should be "yes" or "no". The proposed name "PhysicalSample" although align with standard, but is a little bit confusing, as if I see an element called "PhysicalSample", I would think I need an ID for "PhysicalSample" here.

--- @CharlieG021163 has agreed on this during today's meeting. The change to PhysicalSampleRequired might be reverted back. Once it's reverted back, we will update the status of this issue.

CharlieG021163 commented 5 years ago

ACTION DONE. CHANGED BACK To MASTER: element name = "PhysicalSample" TO element name = "PhysicalSampleRequired".
Even though Physical Sample aligns with updated Part 2, PhysicalSample Required is more explicit to the boolean defined values of "Yes" or "No". Charlie Gifford will submit 95 committee comment to align with B2MML.

gerardmoloneyetpartners commented 4 years ago

Accepted by MESA with modifications. @CharlieG021163 @terryrankine Name changed to "PhysicalSample" from "PhysicalSampleRequired". Did not change "TestSpecificationEvaluatedPropertyType" to "EvaluatedPropertyType". Because all of the B2MML schemas operate in the same namespce, the prefix "TestSpecification" was added to all types that are unique to the test specification schema. Previously this convention was not used, and it came back to bite us when we wanted to make changes and had name overlaps. OperationsTestRequirementID Added TestableObjectID Added This to be added to the January 2020 Sprint.

Dennis-Brandl commented 4 years ago

I agree with the changes.