ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add xxxClassPropertyID to xxxPropertyType for "Maps to" relationships throughout updated 950002 & 950004 models #31

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

THE BACKGROUND and COMMENT IS INCORRECT. SEE REWRITE COMMENT BELOW.

Background

There is 0..* map relationship from a certain object's Property to the object's ClassProperty. The mapping relationship is missing from the current B2MML schema. For example, an EquipmentProperty can be mapped to multiple Equipment Class Properties.

Supporting Document

ISA-950002 JWG5 CDV01 version (2019 12) Table 45 – Equipment property relationships Table 66 – Material definition property relationship roles

Impacted types

B2MML-Equipment.xsd

B2MML-Material.xsd

CharlieG021163 commented 5 years ago

Need to discuss. Should be Identifier Type.

racheliurui commented 5 years ago

@CharlieG021163 want to change the type to back to Identifiertype.

CharlieG021163 commented 5 years ago

REWRITE and CORRECTION of Original Comment.

Background

xxxClassPropertyID attribute was added to xxxPropertyType for "Maps to" Relationship throughout updated Part 2 and Part 4 models.

The "Maps to" relationship from each Property object maps to each 0..1 Class Property. This "Maps to" relationship is missing from the current B2MML schema.

Solution Example Solution. complexType name = "EquipmentProperty" ADD: element name = "EquipmentClassPropertyID" type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/>

Supporting Document

ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.3.5 Operational location property, Table 27 – Operational location property relationship roles 5.4.5 Person property, Table 36 – Person property relationship roles 5.5.5 Equipment property, Table 45 – Equipment property relationships 5.6.5 Physical asset property, Table 55 – Physical asset property relationship roles 5.7.5 Material definition property, Table 66 – Material definition property relationship roles 5.7.7 Material lot property, Table 70 – Material lot property relationship roles 5.10.3 Operations record template, Table 120 – Operations record template relationship roles 5.11.6 Operations event definition property, Table 133 – Operations event definition property relationship roles 5.11.9 Operations event property, Table 138 – Operations event property relationship roles 5.11.10 Operations event record, Table 140 – Operations event record relationship roles 5.11.7 Operations event definition record specification, Table 135 – Operations event definition record specification relationship roles

ISA-950004 JWG5 CDV01 version (2019 12) Clause 5.5 Resource network connection property, Table 8 – Resource network connection property relationship roles 6.16.9 Workflow specification node type property, Table 44 – Workflow specification node type property relationship roles 6.16.11 Workflow specification connection type property, Table 48 – Workflow specification connection type property relationship roles 12.5 Work alert property, Table 84 – Work alert property relationship roles 13.8 Work calendar entry, Table 99 – Work calendar entry relationship roles 13.9 Work calendar entry property, Table 101 – Work calendar entry property relationship roles

Impacted types

B2MML-OperationalLocation.xsd: OperationalLocationPropertyType, DONE B2MML-Equipment.xsd: EquipmentPropertyType, DONE B2MML-Material.xsd: MaterialDefinitionPropertyType DONE B2MML-Material.xsd: MaterialLotPropertyType DONE B2MML-Personnel.xsd: PersonPropertyType DONE B2MML-PhysicalAsset.xsd: PhysicalAssetPropertyType DONE B2MML-OperationsEvent.xsd: OperationsEventDefinitionPropertyType DONE B2MML-OperationsEvent.xsd: OperationsEventPropertyType DONE B2MML-WorkflowSpecification.xsd: WorkflowSpecificationNodePropertyType DONE B2MML-WorkflowSpecification.xsd: WorkflowSpecificationConnectionPropertyType DONE B2MML-WorkAlert.xsd: WorkAlertPropertyType DONE B2MML-WorkCalendar.xsd: WorkCalendarType DONE B2MML-WorkCalendar.xsd: WorkCalendarEntryType DONE NEW: B2MML-ResourceRelationshipNetwork.xsd: RNCTypePropertyType, DONE

gerardmoloneyetpartners commented 4 years ago

I understand this issue, as a missing link between the property to the property class, where the object to the object class is present. easy to see the link on Operations Definition Model. Agreed by team, pending a review for final tick off when charlie has finished working through the list.

CharlieG021163 commented 4 years ago

The REWRITE and CORRECTION of the Original Comment is Completed. Ready for final review and submission to MESA

gerardmoloneyetpartners commented 4 years ago

Agreed

Dennis-Brandl commented 4 years ago

I agree with the change