search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add MaterialDefinitionPropertyID to MaterialLotPropertyType in Material.xsd to align with updated 950002 #33

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

MESA

https://github.com/MESAInternational/B2MML-BatchML/issues/38

Background

To align with the updated 950002, There is 0..* "maps to" association relationship from MaterialLotProperty to MaterialDefinitionProperty. The mapping relationship is missing from the current B2MML schema.

Supporting Document

ISA-950002 JWG5 CDV01 version (2019 12) Table 70 – Material lot property relationship roles

Impacted Types and Solution

B2MML-Material.xsd complexType name = "MaterialLotPropertyType", ADD element name = "MaterialDefinitionPropertyID" type = "MaterialDefinitionPropertyIDType". This aligns to updated ISA-950002 JWG5 CDV01 version (2019 12).

gerardmoloneyetpartners commented 4 years ago

Accepted by MESA with comments Yes, but it should be maxOccurs = "1", as per table 70. To be fixed in the January 2020 Sprint.

CharlieG021163 commented 4 years ago

Agree. We changed the maxOccurs = 1 in more recent issue as well as changed type = "MaterialDefinitionPropertyIDType" to "Identifier Type". I can find issue number later But since it is accepted, it will come out later.

Dennis-Brandl commented 4 years ago

I agree with the change.