search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update BillOfMaterialsID, WorkDefinitionID (Change to WorkMasterID), and BillOfResourcesID elements to unbounded for OperationsDefinitionType and OperationsSegmentType #37

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background OperationsDefinition.xsd

  1. OperationsDefintionType and OperationsSegmentType use WorkDefinitionID, Per the updated 950002, the "corresponds to" association is from the Work Master object, not the Work Definition object. Align with updated 950002.

  2. B2MML is using the an incorrect multiplicity for each relationship target names for OperationsDefinitionType and OperationsSegmentType. Align with updated 950002 Operations Definition Model.

Supporting Documents ISA-950002 JWG5 CDV01 version (2019 12) Clause 6.1.2 Operations definition, Table 145 – Operations definition relationship roles Clause 6.1.5 Operations segment, Table 151 – Operations segment relationship roles

Impacted Types and Solution B2MML-OperationsDefinition.xsd

  1. complexType name = "OperationsDefinitionType" 1.1. CHANGE: WorkDefinitionID TO: WorkMasterID.

1.2. For the following elements:"BillOfMaterialsID", "WorkMasterID", "BillOfResourcesID" CHANGE: minOccurs = "0"/>min TO: Occurs = "0" maxOccurs = "unbounded"/>

  1. complexType name = "OperationsSegmentType" 2.1. CHANGE: WorkDefinitionID TO: WorkMasterID.

2.2. For the following elements: "BillOfMaterialsID", "WorkMasterID", "BillOfResourcesID" CHANGE: minOccurs = "0"/>min TO: Occurs = "0" maxOccurs = "unbounded"/>

racheliurui commented 5 years ago

Table 145 – Operations definition relationship roles

Is WorkDefinitionID refers to "Work Master" in the table?

CharlieG021163 commented 5 years ago

YES, Table 145 – Operations definition relationship roles WorkDefinitionID refers to "Work Master" in the table

racheliurui commented 5 years ago

Work Definition is an abstract type and Work Master is the first-order object. @CharlieG021163 mentioned it's better to directly refer to work master in the schema. Might consider a change to Erdi version.

CharlieG021163 commented 5 years ago

Answer to Rachel Comment above. I agree. Change WorkDefinitionID to WorkMasterID. Change made. Updated Original Comment. Ready for final approval and submission to MESA.

Dennis-Brandl commented 4 years ago

I disagree with making OperationsMaterial Bill a first level object, since it is not reflected in Part 5.