search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update ProcessSegmentType to align with updated 950002 #38

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background Align complexType name = "ProcessSegmentType" in ProcessSegment.xsd with updated 950002 Process Segment Model.

Supporting Documents ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.8.2 Process segment,

Impacted Types and Solution B2MML-ProcessSegment.xsd

CHANGE: #12 element name = "ProcessSegment" TO: element name = "ProcessSegmentChild"

ADD: element name = "DependentProcessSegmentID" type = "IdentifierType" minOccurs = "0" maxOccurs = "unbounded"/> ADD: #32 element name = "ProcessSegmentPatternID" type = "IdentifierType" minOccurs = "0"/>

#2 Since updated 950002 relationship role naming convention only names the target element and not source element, the existing instances of source elements in B2MML shall not be deleted to align with the updated standard but shall change the element name to XXXSourceID to make the role explicit in the object and it B2MML type to be schematically correct, MESA B2MML implementation is inconsistent in it use of source elements across the schema. CHANGE:

These elements are the source of the "Corresponds To" unidirectional relationship, not the target, element; The current element names are very confusing since process segment DOES NOT "correspond to" the source element.

racheliurui commented 5 years ago

as for Update the nested ProcessSegment relationships, I am confused by this proposed change, First, Table 244 only listed 2 nested types, but here we got 3 nested relationships. Second, why a reusable ProcessSegment would reference its parent segment id? That would be hard to maintain, as each time a ProcessSegment being referenced by another ProcessSegment via reusing, the ProcessSegment being reused need to update its definition to add an extra parent.

For the "CorrespondsToWorkMasterID", "CorrespondsToOperationsSegmentID", and "CorrespondsToSegmentRequirementID"part, I didn't find anything from ISA-950002. --Need further reading

racheliurui commented 5 years ago

@CharlieG021163 BTW, the "IncludesPropertiesOfProcessSegmentID" is deleted from the ProcessSegmentType. I believe it's a typo. Could you confirm?

CharlieG021163 commented 5 years ago

"IncludesPropertiesOfProcessSegmentID" SHOULD NOT BE deleted from the ProcessSegmentType. But is a pattern/instance specialization and should be changed to "defined by" relationship per 95 committee comment. Need ISA Decision on #32

CharlieG021163 commented 5 years ago

Updated Original Comment, Ready for final review.

CharlieG021163 commented 5 years ago

The Change of "has properties of" to "defined by" relationship on process segment in 950002 was approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA.

gerardmoloneyetpartners commented 4 years ago

changing and adding some elements missing/incorrect. changing and adding some missing/incorrect sources (compromise on the source/target approach agreed with ISA95 by Charlie).

AGREED GM pointed out ParentID not PatternID on rachels commit reference Charlie will review and ensure the right commit is referenced.

terryrankine commented 4 years ago

Agreed - Make sure all commits which are the implementation of this are referenced from this.

CharlieG021163 commented 4 years ago

Per the Approved Comment for the redefining the exclusive specialization relationship between a process object instance to a object pattern to a "defined by" relationship from a "includes properties of". The target role name was agreed to be xxxPatternID. Older version of the Draft schema have been changed to show this agreed naming convention.

Dennis-Brandl commented 4 years ago

I agree with the change.