ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update WorkDirectiveType in WorkDefinition.xsd to align with updated 950004 #41

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background Align complexType name = "WorkDirectiveType" in WorkDefinition.xsd with updated 950004 Work Definition Model.

Supporting Document ISA-950004 JWG5 CDV01 version (2019 12) Clause 6.6 Work directive relationship roles and attributes, Table 28 – Work directive relationship roles Table 29 – Work directive attributes

Impacted Types and Solution B2MML-WorkDefinition.xsd

Align with updated 950004 Table 28 – Work directive relationship roles CHANGE: #12 element name = "WorkDirective" TO: "WorkDirectiveChild"

ADD: element name = "WorkDirectiveState"
This is a new attribute for Work Directive object to align with other state attributes for the Job Order State Model. Comment approved by 95 Committee at October 28th 2019 meeting.

CHANGE: #2 element name = "JobOrderID" TO: JobOrderSourceID Since updated 950002 relationship role naming convention only names the target element and not source element, the existing instances of source elements in B2MML shall not be deleted to align with the updated standard but shall change the element name to XXXSourceID to make the role explicit in the object and it B2MML type to be schematically correct, MESA B2MML implementation is inconsistent in it use of source elements across the schema. In Table 28, the Job Order element is the source of the "Corresponds To" unidirectional relationship between Work Directive and Job Order objects; element is not the target, so Work Master and Work Directive objects do not "correspond to" the source element and the type should not reference the relationship source in this schema.

racheliurui commented 5 years ago

@CharlieG021163 I didn't find the supporting document to add "WorkDirectiveState" element to "WorkDefinitionType". I am using 2018.11 final version of ISA950004

racheliurui commented 5 years ago

@CharlieG021163 agrees that it's not in current document, this issue might be on-hold.

CharlieG021163 commented 5 years ago

@racheliurui Work Directive State is missing from 950004. Comment being submitted to October 28 ISA-95 Meeting.
950004, Clause 6.6 Work directive relationship roles and attributes, Table 28 – Work directive relationship roles

CharlieG021163 commented 5 years ago

Updated Original Comment. Ready for final review for approval

CharlieG021163 commented 5 years ago

This Change of ADD of WorkDirectiveState element to 950004 approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA.

gerardmoloneyetpartners commented 4 years ago

Agree. Charlie needs to review the original change description.

terryrankine commented 4 years ago

Agreed

CharlieG021163 commented 4 years ago

https://github.com/ETPartners/b2mmlv7beta/commit/8ce6f9eef8d43c3b290892d73556c96e1046bed2#r36903130

Dennis-Brandl commented 4 years ago

See comments on other issues on using the "Child" postfix. I believe that term "Child" does not convey the aggregation of composition relationship. I recommend prefix of "Aggregates” for the aggregation hierarchy and “Contains” for the composition hierarchy.

terryrankine commented 4 years ago

not accepted yet - final review discussion