search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update WorkflowSpecificationNodeTypeType to align with updated ISA-950004 #47

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

https://github.com/MESAInternational/B2MML-BatchML/issues/49

Background Explicitly Align B2MML with updated 950004 Workflow Specification Model, Clause 6.16.7 Workflow specification node type.

Supporting Document ISA-950004 JWG5 CDV01 version (2019 12) Clause 6.16.8 Workflow specification node type Table 43 – Workflow specification node type relationship roles Table 44 – Workflow specification node type attributes

Impacted Types and Solution Related Issues #48, #50, #51
complexType name = "WorkflowSpecificationNodeTypeType"

  1. Global Element 1.1. ADD

  2. Transaction Elements 2.1. ADD: All transaction elements for WorkflowSpecificationNodeType

  3. Simple & Complex Types 3.1. ADD: to incorporate new proposed element

    • 11 element name = "Version", type = "VersionType" minOccurs = "0"/>

    • 9 element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" />

    • 9 element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />

      3.2. CHANGE: #51

    • element name = "Property", type = "WorkflowSpecificationPropertyType" TO: "WorkflowSpecifictionNodeTypeProperty", type = "WorkflowSpecificationNodeTypePropertyType"
      3.3. ADD: Align with updated 950004 Workflow Specification Model.
    • element name = "HierarchyScope", type = "HierarchyScopeType" minOccurs = "0"/> Align with updated 950002 best practice to apply Hierarchy Scope to 1st class objects. This addition was added. Comment approved by ISA-95 Committee at October 28th meeting.

  4. WorkflowSpecificationNodeTypeType Transaction Types 4.1. ADD All transaction types for WorkflowSpecificationNodeTypeType

racheliurui commented 5 years ago 
ADD:
element name = "Version", type = "VersionType" minOccurs = "0"/>
element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" />
element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />

Similiar as #48, from my perspective, the effective from and to control for a workflow (work specification) should be at work specification level not at Node level. A node is an action/ service participated in the flow, it might have a different life cycle when participating in different flows. I agree node can have a version but I didn't see why node needs to "effective from and to."

========================= This is master data. we are proposing any master data would have Effective From and To. This might help with avoiding reference an invalid node type for a node.

racheliurui commented 5 years ago 
ADD: element name = "HierarchyScope", type = "HierarchyScopeType" minOccurs = "0"/> to align with updated Part 2 best practice to apply Hierarchy Scope to 1st class objects, this addition was added and comment submitted to ISA-95 for consideration.

I didn't find supporting document for adding HierarchyScopeType to Node, it makes more sense to describe hierarchy scope in workflow spec.

@CharlieG021163 is proposing a change to ISA95. It can be used to filter out the qualified nodes for a workflow.

racheliurui commented 5 years ago 
ADD
element name = "Property", type = "WorkflowSpecificationPropertyType" TO
"WorkflowSpecifictionNodeTypeProperty", type = "WorkflowSpecificationNodeTypePropertyType"

ISA-950004 6.16.9 Workflow specification node type property

And WorkflowSpecificationNodeTypePropertyType itself is a new Type.

Check the comment of #51. Disagree with using WorkflowSpecifictionNodeTypeProperty.

A lot of dicussion here, Corrected my understanding: I thought here the workflow's property and node property is mixed together when nest, it's not. If a workflow is nested, then acting as a workflowspecnode , it's property is inside the workflowspec tag, and the extended property is outside the workflowspec. Change this to Agree.

CharlieG021163 commented 4 years ago

Why was this submitted to MESA without 48 and original comment not completed? Incorrectly labelled as HIGH. Adjusted to LOW. Decision: Edit or Delete MESA comment.

vitalJP commented 4 years ago

The issue has been closed from the MESA repository.

CharlieG021163 commented 4 years ago

The Change to add Hierarchy Scope to 950004 approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA.

Dennis-Brandl commented 4 years ago

I agree with the change.

gerardmoloneyetpartners commented 4 years ago

@Dennis-Brandl This issue has been agreed here.

It needs to be accepted in to the MESA github (I'm not sure how... by pull request?) and committed in to Version 7.0 If you need a hand with doing this, please give myself and John Kirkman and email to arrange it with you.

Dennis-Brandl commented 4 years ago

This is included in the Mesa International Master Branch!

Dennis

Dennis Brandl

208 Townsend Ct, Suite 200

Cary, NC 27518-8319, USA

+1-919-852-5322 (Office)

+1-919-656-2205 (Cell)

+1-832-201-0554 (Fax)

http://www.brlconsulting.com/ www.brlconsulting.com 

<mailto:DnBrandl@BRLConsulting.com> DnBrandl@BRLConsulting.com

From: gerardmoloneyetpartners notifications@github.com Sent: Monday, September 7, 2020 1:11 AM To: ETPartners/b2mmlv7beta b2mmlv7beta@noreply.github.com Cc: Dennis Brandl dnbrandl@brlconsulting.com; Mention mention@noreply.github.com Subject: Re: [ETPartners/b2mmlv7beta] Update WorkflowSpecificationNodeTypeType to align with updated ISA-950004 (#47)

@Dennis-Brandl https://github.com/Dennis-Brandl This issue has been agreed here.

It needs to be accepted in to the MESA github (I'm not sure how... by pull request?) and committed in to Version 7.0 If you need a hand with doing this, please give myself and John Kirkman and email to arrange it with you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ETPartners/b2mmlv7beta/issues/47#issuecomment-688039608 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBIXAWM3VZSKCDGOHTXMJTSERTOVANCNFSM4IQ65LRA . https://github.com/notifications/beacon/AEBIXAVSSP2MJJ773FIAYXDSERTOVA5CNFSM4IQ65LRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFEBKNOA.gif