search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update WorkflowSpecificationConnectionTypeType to align with updated ISA-950004 #48

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background Align with updated 950004 Workflow Specification Model, Clause 6.16.10 Workflow specification connection type.

Supporting Document ISA-950004 JWG5 CDV01 version (2019 12) Clause 6.16.10 Workflow specification connection type Table 47 – Workflow specification connection type relationship roles Table 48 – Workflow specification connection type attributes

Impacted Types and Solution Related Issues #47, #50, #51
B2MML-WorkflowSpecification.xsd complexType name = "WorkflowSpecificationConnectionTypeType"

  1. Global Element 1.1. ADD

  2. Transaction Elements 2.1. ADD: All transaction elements for WorkflowSpecificationConnectionType

  3. Simple & Complex Types complexType name = "WorkflowSpecificationConnectionTypeType" 3.1. ADD: to incorporate new proposed elements

    • 11 element name = "Version", type = "VersionType" minOccurs = "0"/>

    • 9 element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" />

    • 9 element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />

3.2. CHANGE: #51

3.3. ADD: Align with updated 950004 Workflow Specification Model.

  1. WorkflowSpecificationConnectionTypeType Transaction Types 4.1. ADD All transaction types for WorkflowSpecificationConnectionTypeType
racheliurui commented 5 years ago

From my previous BPM implementation experience, normally we will version control the WorkflowSpecification, not the WorkflowSpecificationConnection.

See if a Workflow changed, then we will have a new definition for the new flow, then the whole new flow will have a version/start time for it.

It's a bit of confusing to version control the connection. Does it mean after that date the connection will not work, and we should switch to new subflow? In that case, the WorkflowSpecification definition containing that connection will already have a new version to represent the change.

To conclude, the change to a workflow spec is better contained at workflow spec level not down to connection level. -- That's my personal opinion to below changes,

ADD:
element name = "Version", type = "VersionType" minOccurs = "0"/>
element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" />
element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
racheliurui commented 5 years ago 
ADD:

element name = "HierarchyScope", type = "HierarchyScopeType" minOccurs = "0"/> to align with updated Part 2 best practice to apply Hierarchy Scope to 1st class objects, this addition was added and comment submitted to ISA-95 for consideration.
element name = "FromWSNodeMultiplicity", type = "DescriptionType" minOccurs = "0"/>
element name = "ToWSNodeMultiplicity", type = "DescriptionType" minOccurs = "0"/>

I didn't find any supporting document about adding HierarchyScope to Workflow specification. And I need to understand "FromWSNodeMultiplicity", to describe a workflow , there should be from and to for one connection, it's confusing with Multiplicity. (Although the original allows 0..* connections).

See comments by Charlie.

racheliurui commented 5 years ago 
ADD:
element name = "Dependency" type="DependencyType"/>
element name = "DependencyFactor" type="ValueType" minOccurs="0"/>

Agree with above 2 elements being added.

CharlieG021163 commented 5 years ago

  1. As explained, many Level 3 MES workflow applications/packages and batch recipe application have NodeType and and ConnectionType as Master Data that is validated for reuse.

  2. HierachyScope is missing from updated 950004. Comment being submitted to October 28th meeting to add.

  3. 950004, Clause 6.16.10 Workflow specification connection type Table 47 –Workflow specification connection type attributes

Attribute name Description
From multiplicity Defines the multiplicity of the “from” connection: one, one or more, zero or more, or an allowed range.
To multiplicity Defines the multiplicity of the “to” connection: one, one or more, zero or more, or an allowed range.
racheliurui commented 4 years ago

Agreed.

CharlieG021163 commented 4 years ago

Original issue comment updated. Final

CharlieG021163 commented 4 years ago

This Change to ADD Hierarchy Scope to 950004 approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA.

gerardmoloneyetpartners commented 4 years ago

Agreed.

Dennis-Brandl commented 4 years ago

I agree with the change.