ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Delete WorkflowSpecificationTypeType from WorkflowSpecification.xsd to align with updated 950004 #50

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background WorkflowSpecification.xsd DELETE complexType name = "WorkflowSpecificationTypeType", In the B2MML, this is an abstract type that simply refers only to two types, WorkflowSpecificationNodeTypeType and WorkflowSpecificationConnectionTypeType.
It is simply not needed especially since these types are individually exchanged as first order objects as master data.
Second, the name, WorkflowSpecificationType, is confusing to user since it implies that there are different types of a Workflow Specification which there is not in the updated ISA-950004.

Impact Analysis

Supporting Document ISA-950004 JWG5 CDV01 version (2019 12) Clause, 6.16.1 Workflow specification model, Figure 5 – Workflow specification model Clause 6.16.8 Workflow specification node type, Table 43 – Workflow specification node type relationship roles Clause 6.16.10 Workflow specification connection type, Table 47 – Workflow specification connection type relationship roles

Impacted Types and Solution Related Issues: #43, #45, #46, #47, #48 B2MML-WorkflowSpecification.xsd

  1. Global Element
    1.1. DELETE:
  2. Transaction Elements 2.1. DELETE: All transaction elements for WorkflowSpecificationType
  3. Simple & Complex Types 3.1. DELETE: complexType name = "WorkflowSpecificationTypeType"
  4. WorkflowSpecificationTypeType Transaction Types 4.1. DELETE: All transaction types for WorkflowSpecificationTypeType

B2MML-Extension.xsd

  1. DELETE:
racheliurui commented 5 years ago

Comment, 1) By understanding what information WorkflowSpecification needs to include, I agree that WorkflowSpecificationTypeType sounds like redundant and confusing.

2) I do feel that the version mentioned in WorkflowSpecificationTypeType could be preserved or promoted as an attribute to WorkflowSpecificationInformationType.

As from my experience, when we design a BPM flow, other than define how the flow works, we would have a version concept to make sure when the flow definition evolves, the old workflow definition can be smoothly phased out.

So in summary,

CharlieG021163 commented 5 years ago

@racheliurui The Version, EffectiveFrom and EffectiveTo elements are on first class master data objects in WorkflowSpecificationInformationType.
complexType name = "WorkflowSpecificationType" complexType name = "WorkflowSpecificationNodeTypeType" complexType name = "WorkflowSpecificationConnectionTypeType" XXXInformationType should never have a version; only first class objects contained in it.

racheliurui commented 5 years ago

Understood, XXXInformationType should never have a version; but first-class master data objects in XXXInformationType should have a version.

CharlieG021163 commented 4 years ago

Original issue comment updated. Final

Dennis-Brandl commented 4 years ago

I agree with the change.