search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add specific property types to replace common WorkflowSpecificationPropertyType for WorkflowSpecificationNode, NodeType, Connection, and ConecectionType in WorkflowSpecification.xsd to align with updated 950004 #51

Open racheliurui opened 5 years ago

racheliurui commented 5 years ago

Background

  1. The Common type, WorkflowProperty, in B2MML 7.0 Beta was used for all Workflow Specification Property Types. This named type is the explicit object name in the updated 950004 Workflow Specification Model for the property object of the Workflow Specification object.
  2. WorkflowSpecificationPropertyType must only be used for WorkflowSpecificationType and be replace with specific property types for each object type to align with updated 950004 Workflow Specification model. This reduces use confusion and make explicit the property mappings from instance to type definition.
  3. The common property type schema make relationship elements between the common group schema very confusing for the B2MML user.

Supporting Document ISA-950004 JWG5 CDV01 version (2019 12) Clause 6.16.5 Workflow specification node property Table 37 – Workflow specification node property relationship roles Table 38 – Workflow specification node property attributes Clause 6.16.7 Workflow specification connection property, Table 41 – Workflow specification connection property relationship roles Table 42 – Workflow specification connection property attributes Clause 6.16.9 Workflow specification node type property Table 45 – Workflow specification node type property relationship roles Table 46 – Workflow specification node type property attributes Clause 6.16.11 Workflow specification connection type property Table 49 – Workflow specification connection type property relationship roles Table 50 – Workflow specification connection type property attribute

Impacted Types and Solution B2MML-WorkflowSpecification.xsd

  1. complexType name = WorkflowSpecificationPropertyType This Common property type shall be only apply to WorkflowSpecificationType and not to all property types; It shall be replaced with specific property types to align with updated 950004 Workflow Specification model.

  2. ADD:

    • complexType name = "WorkflowSpecificationNodePropertyType".
    • complexType name = "WorkflowSpecificationNodeTypePropertyType".
    • complexType name = "WorkflowSpecificationConnectionPropertyType".
    • complexType name = "WorkflowSpecificationConnectionTypePropertyType".

B2MML-Extension.xsd

  1. ADD:
  2. ADD:
  3. ADD:
  4. ADD:
racheliurui commented 5 years ago

ISA-950004 Table 36 – Workflow specification node property relationship roles

Workflow specification node type property Workflow specification node type property 0..1 Maps to If the workflow specification node supports a workflow specification node type, the workflow specification node type property is applied in this workflow specification node property(s). This workflow specification node property maps to the corresponding workflow specification node type property.

Above is saying, when we nest workflow specification. One workflow specification can become another workflow specification's node. So there's no fundamental difference between the property for a node or for a workflow specification. Thus I think adding WorkflowSpecificationNodePropertyType is redundant. WorkflowSpecificationPropertyType contains the same information. WorkflowSpecificationNodeTypePropertyType is something I didn't find supporting document.

Disagrees with adding WorkflowSpecificationNodePropertyType and WorkflowSpecificationNodeTypePropertyType.

racheliurui commented 5 years ago

Supporting document

ISA-950004 Table 40 – Workflow specification connection property relationship roles Table 41 – Workflow specification connection property attributes Table 48 – Workflow specification connection type property relationship roles Table 49 – Workflow specification connection type property attributes

Agrees with adding WorkflowSpecificationConnectionPropertyType and WorkflowSpecificationConnectionTypePropertyType

CharlieG021163 commented 5 years ago

@racheliurui Please confirm that you agree now with adding WorkflowSpecificationNodePropertyType and WorkflowSpecificationNodeTypePropertyType.

racheliurui commented 5 years ago

Agree

Dennis-Brandl commented 4 years ago

I agree with the change.