Open factoryiq opened 5 years ago
To align with B2MML Design method for doing enumerations, Updated common schema
Moved SpatialFormatDataType to location in Common schema in alphabetic order of type name.
CHANGED:
But regards to change to Value tag, our current payload is like this,
<gac:SpatialDefinition>
<gac:Value>
POLYGON ((595780.0 1222899.7, 595800.0 1222899.7, 595800.0 1222879.7, 595780.0 1222879.7, 595780.0 1222899.7))
</gac:Value>
<gac:Format>WKT</gac:Format>
<gac:SRID>Local</gac:SRID>
<gac:SRIDAuthority/>
</gac:SpatialDefinition>
If we change it to Value, I saw the UnitOfMeasure has SVG as one of the allowed value. Is there plans to change the UnitOfMeasure to add the standard?
I agree with the proposed change number 2. In our practice, I have tried to find the allowed list of the standards to use as ID. It's great that there's an existing list and naming convention to the name of the standard to avoid integration issues.
@racheliurui Proposed change 1: Not sure what your are referring to? SVG is an enumeration value of SpatialDefinitionFormat1Type .
Change: element name "Value" type ="TextType" to "ValueType" What's the difference between TextType and ValueType?
ValueType: need to have value, UnitOfMeasure TextType: just a string
@CharlieG021163 agreed to change the ValueType back to TextType. Will change back and then agree.
From discussion, agreed to not change element name "Value" type ="TextType" to "ValueType"; Keep as type = "TextType". Original comment updated to this agreement.
Agreed
Copy of Original Issue Comment with Related Issue References: #58 and #81 Background In Common Schema, complexType name="SpatialDefinitionType", change "Format" element from IdentifierType to "SpatialDefinitionFormatType") so a list of enumerations is added in Issue #58 to comply and align to updated ISA-950002, Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition and Example 4.
Supporting Documents ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition Example 4. List of Possible Defined Values.
Impacted Types and Solution B2MML-Common.xsd, "SpatialDefinitionType"
In Common.xsd, complexType name = SpatialDefninitionType", Align with updated 950002 Clause 5.2, Table 19 – Attributes of spatial definition. CHANGE: Element name "Format" from "IdentifierType" TO: "SpatialDefinitionFormatType"
Ready to be Authorised for MESA Submission
This should have been submitted at same time as Issue #58
I am ok with the change, BUT THE STANDARD ONLY LISTS THESE AS EXAMPLES (see page 42 Example 4). Normally, when examples are given the list is not enumerated, only if the standard says "the defined values are" is the list enumerated.
I would recommend not accepting this change, because it breaks the pattern.
Background In Common.xsd, complexType name="SpatialDefinitionType", CHANGE "Format" element from IdentifierType to "SpatialDefinitionFormatType" which then ADDs a list of enumerations is added in Issue #58 to comply and align to updated ISA-950002, Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition and Example 4.
Supporting Documents ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition Example 4. List of Possible Defined Values.
Impacted Types and Solution B2MML-Common.xsd, "SpatialDefinitionType"
complexType name = SpatialDefninitionType", Align with updated 950002 Clause 5.2, Table 19 – Attributes of spatial definition. CHANGE: Element name "Format" from "IdentifierType" TO: "SpatialDefinitionFormatType"