search

ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Update or Add all ID element in B2MML Schema and Types as "required" to align with updated 950002 and 950004. #59

Open CharlieG021163 opened 5 years ago

CharlieG021163 commented 5 years ago

https://github.com/MESAInternational/B2MML-BatchML/issues/51

Background The updated 950002 and 950004 has defined all ID attributes on objects as "required" or mandatory. Many B2MML schema and types have the IDs as optional (0..1) or are missing an ID.

Solution CHANGE: XXXType. element name = "ID" type = "IdentifierType" minOccurs = "0"/>. TO: XXXType. element name = "ID" type = "IdentifierType" /> OR ADD: XXXType. element name = "ID" type = "IdentifierType" />

Supporting Document Most objects in 950002 and 950004 have a required ID attribute. Refer to All object attribute tables in 950002 and 950004.

racheliurui commented 5 years ago

Agreed with this change.

gerardmoloneyetpartners commented 4 years ago

@CharlieG021163 @terryrankine MESA feedback that we need to review: This needs to go to the ISA 95 committee. B2MML reflects the standard. Recommend closing this issue.

Dennis-Brandl commented 4 years ago

I agrre, change it where it lines up with ISA 95

gerardmoloneyetpartners commented 4 years ago

I will move this issue to the 'Final Review' milestone, as MESA has closed this issue instead of accepting it (as suggested here in etp github on Dennis' last comment.

I've commented on the MESA github at the closed issue, to reconsider as I have since provided Dennis with the ISA-95 draft updates and pointed back to the committee minutes that may have discussed guidance on this proposed change. https://github.com/MESAInternational/B2MML-BatchML/issues/51