ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add "OperationsRecordSpecTemplatePatternID" and "DefinitionType" element to OperationsRecordSpecTemplateType in Common.xsd to support 950002 "maps to" relationship of Operations Event Definition Record Specification object #62

Open CharlieG021163 opened 5 years ago

CharlieG021163 commented 5 years ago

Background

  1. 950002: In the Operations Event Model, Operation Event Definition Record Specification has a "map to" association relationship with a 0..1 multiplicity to Operations Event Class Record Specification as a pattern of the instance.
  2. Both Operation Event Definition Record Specification and Operations Event Class Record Specification objects use the abstract Operations Record Specification object which does not have an exclusion specialization (pattern) relationship to support the "maps to" relationship of the concrete objects in No. 1 above.
  3. In B2MML OperationsEvent.xsd, both OperationEventDefinitionType and OperationsEventClassType use the RecordSpecification element with type = "OperationsRecordSpecTemplateType" for the both related specification objects.
  4. B2MML Common.xsd, "OperationsRecordSpecTemplateType" does not have an element to support the "maps to" relationship (0..1) for a Definition Record to Class Record as a pattern.

Supporting Document ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.10.1 Operations record model (abstract), Figure 17 – Operations record model (abstract) Clause 5.10.2 Operations record specification template (abstract), Table 118 – Operations record specification template relationship roles Clause 5.11.1 Operations event model, Figure 18 – Operations event model Clause 5.11.7 Operations event definition record specification, Table 135 – Operations event definition record specification relationship roles

Impacted types and Solution Common.xsd, complexType name="OperationsRecordSpecTemplateType" An 95 Committee Comment was approved at the ISA95/JWG5 October 2109 meeting to update this object with the "Defined by" relationship with a target role of "OperationsRecordSpecTemplatePatternID" and with the DefinitionType attribute. ADD: ADD:

racheliurui commented 4 years ago

I want to understand the underlyingly reason for changing this.

For example,

But I noticed this change is WIP. So waiting for more details about it.

CharlieG021163 commented 4 years ago

@racheliurui Re-review. I have completed issue explanation above and addition to schema.

racheliurui commented 4 years ago

ISA change.

CharlieG021163 commented 4 years ago

Copy of Original Comment with Dependent Referenced Issues: #31, #32, #35

Background

  1. 950002: In the Operations Event Model, Operation Event Definition Record Specification has a "map to" association relationship with a 0..1 multiplicity to Operations Event Class Record Specification as a pattern of the instance.
  2. Both Operation Event Definition Record Specification and Operations Event Class Record Specification objects use the abstract Operations Record Specification object which does not have an exclusion specialization (pattern) relationship to support the "maps to" relationship of the concrete objects in No. 1 above.
  3. In B2MML OperationsEvent.xsd, both OperationEventDefinitionType and OperationsEventClassType use the RecordSpecification element with type = "OperationsRecordSpecTemplateType" for the both related specification objects.
  4. B2MML Common.xsd, "OperationsRecordSpecTemplateType" does not have an element to support the "maps to" relationship (0..1) for a Definition Record to Class Record as a pattern.

Supporting Document ISA-950002 Clause 5.10.1 Operations record model (abstract), Figure 17 – Operations record model (abstract) Clause 5.10.2 Operations record specification template (abstract), Table 118 – Operations record specification template relationship roles Clause 5.11.1 Operations event model, Figure 18 – Operations event model Clause 5.11.7 Operations event definition record specification, Table 135 – Operations event definition record specification relationship roles

Impacted types and Solution Common.xsd complexType name="OperationsRecordSpecTemplateType" An 95 Committee Comment was approved at the ISA95/JWG5 October 2109 meeting to update this object with the "Defined by" relationship with a target role of "OperationsRecordSpecTemplatePatternID" and with the DefinitionType attribute.

ADD:

ADD:

CharlieG021163 commented 4 years ago

This Change to 950002 approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA. complexType name="OperationsRecordSpecTemplateType" An 95 Committee Comment was approved at the ISA95/JWG5 October 2109 meeting to update this object with the "Defined by" relationship with a target role of "OperationsRecordSpecTemplatePatternID" and with the DefinitionType attribute.

gerardmoloneyetpartners commented 4 years ago

Agreed

gerardmoloneyetpartners commented 4 years ago

Agreed

Dennis-Brandl commented 4 years ago

I agree with the change.