ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add ActionType and Action1Type to Common.xsd for defined values of Action element in "OperationsRecordSpecTemplateType" and "OperationsRecordTemplateType" #69

Open CharlieG021163 opened 5 years ago

CharlieG021163 commented 5 years ago

https://github.com/MESAInternational/B2MML-BatchML/issues/52

To align with Updated 95002, Operations Record Model Solution

  1. complexType name="OperationsRecordSpecTemplateType" element name="Action" CHANGE: type="IdentifierType" minOccurs="0" maxOccurs="unbounded"/> TO: type="ActionType" minOccurs="0"/>

  2. complexType name="OperationsRecordType" element name="Action" CHANGE: type="IdentifierType" minOccurs="0" maxOccurs="unbounded"/> TO: type="ActionType" minOccurs="0"/

  3. ADD ActionType and Action1Type to Common.xsd for defined values of Action element in "OperationsRecordSpecTemplateType" and "OperationsRecordSpecTemplateType"

    
    <xsd:complexType name="Action1Type">
        <xsd:simpleContent>
            <xsd:restriction base="CodeType">
                <xsd:enumeration value="Added"/>
                <xsd:enumeration value="Deleted"/>
                <xsd:enumeration value="Changed"/>
                <xsd:enumeration value="Observed"/>
                <xsd:enumeration value="Other"/>
            </xsd:restriction>
        </xsd:simpleContent>
    </xsd:complexType>    
    
    <!--     -->    
    <xsd:complexType name="ActionType">
        <xsd:annotation> 
            <xsd:documentation>

The permitted set of actions applied to the operations record entry template object in the operations record template by the publisher.

Defined values for action are added, changed, deleted, and observed. If no action is specified, this is equivalent to all actions being allowed. </xsd:documentation> </xsd:annotation>

``` **Supporting Document** _ISA-950002 JWG5 CDV01 version (2019 12)_ Clause 5.10.2 Operations record specification template (abstract), Table 119 – Operations record specification template attributes Clause 5.10.3 Operations record template, Table 121 – Operations record template attributes **Impacted types** B2MML-Common.xsd: OperationsRecordSpecTemplateType B2MML-Common.xsd: OperationsRecordTemplateType
racheliurui commented 5 years ago

Agreed.

gerardmoloneyetpartners commented 4 years ago

Accepted by MESA with following comments: Implemented as OperationsRecordActionType, instead of just ActionType. We have found that adding adjectives in front of common words is really helpful. This will be part of the January 2020 Sprint.

Dennis-Brandl commented 4 years ago

I agree with the change.

gerardmoloneyetpartners commented 4 years ago

https://github.com/MESAInternational/B2MML-BatchML/issues/52 in MESA github was closed on 14/8/20. changes are not as proposed, so moving this to the 'final review' milestone until I can check the variance on the fix implemented by MESA