Open CharlieG021163 opened 5 years ago
@CharlieG021163 I noticed you have a defined value with the character of & "&" is the reserved character for XML, what you've suggested will make that XSD failed to be parsed. Refer to below URL, https://www.w3.org/TR/xml/#syntax
So can R&D being replaced by "Research and Development" ?
CHANGE: element name = "OperationsEventType" type = "OperationsTypeType" TO: type = "OperationsEventTypeType"
For this change, in "Table 132 – Operations event definition attributes" , the attribute name is " Operations type", with a description of "Describes the category of operation.", why here you recommend to change the type to "OperationsEventTypeType"?
CHANGE: element name = "OperationsEventLevel" type = "NumericType" TO: type = "OperationsEventLevelType"
For this change, the table saying "Defined values are Level 3 and Level 4." why you are defining the level from Level 2?
Other than above-raised issues, agree with the rest of the changes.
First, this issue also applies to OperationsEventDefinitionType in OperationsEvent.xsd. and the new types are added to Common.xsd. I have updated the original issue above to reflex this.
Responses to Rachel's comments above.
Agreed. Change R&D to "Research and Development" in Common.xsd: EnterpriseFunctionType. Change DONE.
Disagree. Please re-review. Yes. Table 132 has an Operations Type attribute BUT the table also has an Operations Event Type attribute which is not the same attribute or B2MML type as operations type.
CHANGE: element name = "OperationsEventLevel" type = "NumericType" TO: type = "OperationsEventLevelType" Yes, the table says "Defined values are Level 3 and Level 4." why you are defining the level from Level 2. But what was learned during the BHP and Biogen implementation is that there are Level 2 Operations Events from Level 2 that are feedback on workflow specification states and transitions during execution. I am submitting a 95 committee commit for table change.
Agree
This Change to 950002 for adding Level 2 as a defined value to "OperationsEventLevelType" for Operations Event and Operations Event Definition was approved by ISA-95 and JWG5 Committee at Oct 2019 Meeting. Submit Issue to MESA.
Need to update transactions with Notify Transactions.
I agree with the change.
To align with Updated 95002, Operations Event Model. B2MML does not address the defined value for 4 elements in the OperationsEvent.xsd:
Solution OperationsEvent.xsd complexType name = "OperationsEventDefinitionType" and
complexType name = "OperationsEventType" .
CHANGE: element name = "OperationsEventType" type = "OperationsTypeType" TO: type = "OperationsEventTypeType" CHANGE: element name = "OperationsEventLevel" type = "NumericType" TO: type = "OperationsEventLevelType" CHANGE: element name = "MOMFunction" type = "IdentifierType" TO: type = "MOMFunctionType"
CHANGE: element name = "EnterpriseFunction" type = "IdentifierType" TO: type = "EnterpriseFunctionType"
minOccurs = "0" maxOccurs = "unbounded"/>
Common.xsd ADD: "OperationsEventTypeType" ADD: "OperationsEventLevelType" ADD: "MOMFunctionType" ADD: "EnterpriseFunctionType"
Supporting Document ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.11.5 Operations event definition, Table 132 – Operations event definition attributes Clause 5.11.8 Operations event, Table 137 – Operations event attributes
Impacted types B2MML-OperatrionsEvent.xsd: OperationsEventDefinitionType B2MML-OperatrionsEvent.xsd: OperationsEventType New B2MML-Common.xsd: OperationsEventTypeType New B2MML-Common.xsd: OperationsEventLevelType New B2MML-Common.xsd: MOMFunctionType New B2MML-Common.xsd: EnterpriseFunctionType