ETPartners / b2mmlv7beta

b2mmlv7beta for review
2 stars 3 forks source link

Add SpatialDefinition element to any B2MML schema missing element per updated 950002. #81

Open CharlieG021163 opened 5 years ago

CharlieG021163 commented 5 years ago

Background In updated 950002 and 950004, the Spatial Definition attribute was added to the resource objects and process definition objects. B2MML 7.0 Beta is missing a some instances.

Supporting Document ISA-950002 JWG5 CDV01 version (2019 12) Clause 5.3.4 Operational location, Table 26 – Operational location attributes Clause 5.4.4 Person, Table 35 – Person attributes Clause 5.5.4 Equipment, Table 44 – Equipment attributes Clause 5.6.4 Physical asset, Table 54 – Physical asset attributes Clause 5.7.4 Material definition, Table 65 – Material definition attributes Clause 5.7.6 Material lot, Table 69 – Material lot attributes Clause 5.7.8 Material sublot, Table 73 – Material sublot attributes Clause 5.8.4 Personnel segment specification, Table 80 – Personnel segment specification attributes Clause 5.8.6 Equipment segment specification, Table 84 – Equipment segment specification attributes Clause 5.8.8 Physical asset segment specification, Table 88 – Physical asset segment specification attributes Clause 5.8.10 Material segment specification, Table 92 – Material segment specification attributes Clause 6.1.7 Personnel specification, Table 156 – Personnel specification attributes Clause 6.1.9 Equipment specification. Table 160 – Equipment specification attributes Clause 6.1.11 Physical asset specification , Table 164 – Physical asset specification attributes Clause 6.1.13 Material specification, Table 168 – Material specification attributes Clause 6.2.6 Personnel requirement, Table 183 – Personnel requirement attributes Clause 6.2.8 Equipment requirement, Table 187 – Equipment requirement attributes Clause 6.2.10 Physical asset requirement, Table 191 – Physical asset requirement attributes Clause 6.2.12 Material requirement, Table 195 – Material requirement attributes Clause 6.3.6 Personnel actual, Table 209 – Personnel actual attributes Clause 6.3.8 Equipment actual, Table 213 – Equipment actual attributes Clause 6.3.10 Physical asset actual, Table 217 – Physical asset actual attributes Clause 6.3.12 Material actual, Table 221 – Material actual attributes Clause 6.4.3 Personnel capability, Table 228 – Personnel capability attributes Clause 6.4.5 Equipment capability, Table 232 – Equipment capability attributes Clause 6.4.7 Physical asset capability, Table 236 – Physical asset capability attributes Clause 6.4.9 Material capability, Table 240 – Material capability attributes

Impacted Types and Solution CHECKED and ADDED for missing element: element name="SpatialDefinition" type="SpatialDefinitionType" minOccurs = "0" />

B2MML-OperationalLocation.xsd, OperationalLocationType --OK B2MML-Personnel.xsd, PersonType --OK B2MML-Equipment.xsd, EquipmentType --OK B2MML-PhysicalAsset.xsd, PhysicalAssetType --OK B2MML-Material.xsd, MaterialDefinitionType --OK MaterialLotType --OK MaterialSublotType -- ADDED

B2MML-ProcessSegment.xsd PersonnelSegmentSpecificationType -- OK EquipmentSegmentSpecificationType -- OK PhysicalAssetSegmentSpecificationType -- OK MaterialSegmentSpecificationType -- OK

B2MML-Common.xsd OpPersonnelRequirementType -- OK OpEquipmentRequirementType -- OK OpPhysicalAssetRequirementType -- OK OpMaterialRequirementType -- ADDED OpPersonnelSpecificationType -- ADDED OpEquipmentSpecificationType --ADDED OpPhysicalAssetSpecificationType --ADDED OpMaterialSpecificationType --ADDED OpPersonnelCapabilityType --OK OpEquipmentCapabilityType --OK OpPhysicalAssetCapabilityType --OK OpMaterialCapabilityType --OK

B2MML-OperationsPerformanceTypes.xsd OpPersonnelActualType --OK OpEquipmentActualType --OK OpPhysicalAssetActualType --OK OpMaterialActualType --OK

racheliurui commented 5 years ago

Agree

CharlieG021163 commented 5 years ago

Copy of Original Issue Comment with Related Issue References: #57 and #58 Background In updated 950002 and 950004, the Spatial Definition attribute was added to the resource objects and process definition objects. B2MML 7.0 Beta is missing a some instances.

Supporting Document 950002 Clause 5.3.4 Operational location, Table 26 – Operational location attributes Clause 5.4.4 Person, Table 35 – Person attributes Clause 5.5.4 Equipment, Table 44 – Equipment attributes Clause 5.6.4 Physical asset, Table 54 – Physical asset attributes Clause 5.7.4 Material definition, Table 65 – Material definition attributes Clause 5.7.6 Material lot, Table 69 – Material lot attributes Clause 5.7.8 Material sublot, Table 73 – Material sublot attributes Clause 5.8.4 Personnel segment specification, Table 80 – Personnel segment specification attributes Clause 5.8.6 Equipment segment specification, Table 84 – Equipment segment specification attributes Clause 5.8.8 Physical asset segment specification, Table 88 – Physical asset segment specification attributes Clause 5.8.10 Material segment specification, Table 92 – Material segment specification attributes Clause 6.1.7 Personnel specification, Table 156 – Personnel specification attributes Clause 6.1.9 Equipment specification. Table 160 – Equipment specification attributes Clause 6.1.11 Physical asset specification , Table 164 – Physical asset specification attributes Clause 6.1.13 Material specification, Table 168 – Material specification attributes Clause 6.2.6 Personnel requirement, Table 183 – Personnel requirement attributes Clause 6.2.8 Equipment requirement, Table 187 – Equipment requirement attributes Clause 6.2.10 Physical asset requirement, Table 191 – Physical asset requirement attributes Clause 6.2.12 Material requirement, Table 195 – Material requirement attributes Clause 6.3.6 Personnel actual, Table 209 – Personnel actual attributes Clause 6.3.8 Equipment actual, Table 213 – Equipment actual attributes Clause 6.3.10 Physical asset actual, Table 217 – Physical asset actual attributes Clause 6.3.12 Material actual, Table 221 – Material actual attributes Clause 6.4.3 Personnel capability, Table 228 – Personnel capability attributes Clause 6.4.5 Equipment capability, Table 232 – Equipment capability attributes Clause 6.4.7 Physical asset capability, Table 236 – Physical asset capability attributes Clause 6.4.9 Material capability, Table 240 – Material capability attributes

Impacted Types and Solution CHECKED and ADDED for missing B2MML element: element name="SpatialDefinition" type="SpatialDefinitionType" minOccurs = "0" />

B2MML-OperationalLocation.xsd, OperationalLocationType --OK B2MML-Personnel.xsd, PersonType --OK B2MML-Equipment.xsd, EquipmentType --OK B2MML-PhysicalAsset.xsd, PhysicalAssetType --OK B2MML-Material.xsd --OK MaterialDefinitionType --OK MaterialLotType --OK MaterialSublotType -- ADDED

B2MML-ProcessSegment.xsd PersonnelSegmentSpecificationType -- OK EquipmentSegmentSpecificationType -- OK PhysicalAssetSegmentSpecificationType -- OK MaterialSegmentSpecificationType -- OK

B2MML-Common.xsd OpPersonnelRequirementType -- OK OpEquipmentRequirementType -- OK OpPhysicalAssetRequirementType -- OK OpMaterialRequirementType -- ADDED OpPersonnelSpecificationType -- ADDED OpEquipmentSpecificationType --ADDED OpPhysicalAssetSpecificationType --ADDED OpMaterialSpecificationType --ADDED OpPersonnelCapabilityType --OK OpEquipmentCapabilityType --OK OpPhysicalAssetCapabilityType --OK OpMaterialCapabilityType --OK

B2MML-OperationsPerformanceTypes.xsd OpPersonnelActualType --OK OpEquipmentActualType --OK OpPhysicalAssetActualType --OK OpMaterialActualType --OK

CharlieG021163 commented 5 years ago

@vitalJP Updated Original Comment. Update MESA Issue

Dennis-Brandl commented 4 years ago

I agree with the change.