search

ETS-Next-Gen / writing_observer

Writing Observer and Learning Observer: A system for monitoring learning process data, with an initial focus on writing process data from Google Docs.
https://learning-observer.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
11 stars 9 forks source link

initial start of remaking makefile #130

Closed bradley-erickson closed 6 months ago

bradley-erickson commented 8 months ago

This removes extra npm commands we attempt to run and instead relies on the Makefile for installing the LODRC.

pmitros commented 7 months ago

On the whole, this looks good. I'd like to understand this better (questions left in-line; those aren't requests for changes, but I'd like to understand). I think the key changes I'd like to see:

  1. Some way to build the extension (even the crude one of just printing out what to run)
  2. pylint should be available as an option, with the right set of options
  3. Either an understanding of why we manage virtualenv explicitly, or a move back to managing it implicitly. By my read, this adds complexity both to the code and to the use of the system (we can't leverage that people know how to use virtualenv themselves; they need to relearn our wrapper), and reduces flexibility (e.g. installing system-wide).