Added dotpay CHK parameter support and Symfony version requirments.

ETSGlobal / ETSPaymentDotpayBundle

A Dotpay provider for JMSPaymentCoreBundle

9 stars 13 forks source link

Added dotpay CHK parameter support and Symfony version requirments. #3

Open pawellen opened 10 years ago

pawellen commented 10 years ago

1 changed: Symfony version requirments change to <2.4

1 added: Added support of CHK parameter. CHK parameter is used by dotpay do sing payment request. It is used to avoid generation of payments by anyone. The problem is that anyone can use this form https://ssl.dotpay.pl/payment/index.php or send false request to doypay about new payment. In this case you can generate many 0,01 transaction for witch the DotPay customer have to pay fee. The CHK parameter can be enabled by contact dotpay support tech@dotpay.pl. Email must be send from email associated with dotpay account.

ClementGautier commented 10 years ago

Please:

do the code review
add a test for the generateChk function
squash your commits using rebase

After that I will merge ;)

pawellen commented 10 years ago

Okej, I will do all the stuff, sorry for mess in my code, big thx for help!! :)

ch3ric commented 10 years ago

@pawellen @maciek thanks for this PR!

Please

add unit tests for the methods generateChk and generateRecipientChk
squash your commits (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) so that we can merge this PR

ch3ric commented 8 years ago

Hi @pawellen,

I'd love to merge all the features you added in this PR. Could you please squash your commits and rebase so that we can merge. Also it would be great to add some phpunits for the methods generateChk and generateRecipientChk

Thanks

nicolas-grevin commented 5 years ago

This PR has has moved to https://github.com/ETSGlobal/ETSPaymentDotpayBundle/pull/15