ETSGlobal / ETSPaymentOgoneBundle

An Ogone provider for JMSPaymentCoreBundle
12 stars 16 forks source link

Sha1Out not working right #24

Closed igormancos closed 10 years ago

igormancos commented 10 years ago

After research I detect:

Sha1Out.php line 106 - this code cut the "NCERROR=0", need be if ($value == '') {

FeedbackResponse.php, function setValuesFromRequest() - here need add not only self:$fields, because i.e "PM", "CN" and other participate in hash too. can use:

foreach ($request->query->all() as $field => $v) { $this->addValue($field, $v); }

igormancos commented 10 years ago

and for second issue (FeedbackResponse) need collect data from GET and POST, because on Ogone this is configurable.

foreach ($request->query->all() as $field => $v) { $this->addValue($field, $v); }

foreach ($request->request->all() as $field => $v) { $this->addValue($field, $v); }

baruica commented 10 years ago

$request->get() already retrieves values from GET, PATH, POST, in this order.