search

EUA / wxHexEditor

wxHexEditor official GIT repo
http://www.wxhexeditor.org
GNU General Public License v2.0
558 stars 118 forks source link

Search fixes: #188

Closed Alzigopri closed 11 months ago

Alzigopri commented 2 years ago 
Fix case insensitive search
Fix buffer overrun
Fix backward search
fenugrec commented 1 year ago

Promising, but would be nice if it was split in at least 3 commits, with some additional explanations in the commits, in particular regarding the EndModal changes, the unrelated SSE2 changes, etc. As is, it's nearly impossible to review.

Alzigopri commented 1 year ago

Why do you bother about patches to the project which hasn't been updated for 2 years? It wouldn't be merged anyway :-)

fenugrec commented 1 year ago

Because I, and others, may use it in our own fork !

EUA commented 11 months ago

I review the codes. I don't catch where I make a mistake. But if it works like that, okay. I am happy with.