EUA / wxHexEditor

wxHexEditor official GIT repo
http://www.wxhexeditor.org
GNU General Public License v2.0
562 stars 121 forks source link

TAGS panel: Offset base selection hexadecimal #203

Open schrmh opened 1 year ago

schrmh commented 1 year ago

image On the right you can see that the offset in the tags panel is not hexadecimal while I work with hexadecimal offsets in the hex editor. Optimally the offset representation in the tags panel changes when the offset representation is changed in the main part of the hex editor.

EUA commented 1 year ago

You know what, you are right. Does block size need to be converted to hex also? Or it's okay if it sits in decimal notion?

schrmh commented 1 year ago

Block size in this case only shows how many blocks are part of a tag, right (the value after the :)? I don't think I would personally ever need that in anything but decimal.

If anything, the N/A at the bottom at "Selected Blocks" could show Hex as well (or Dec with Hex in () after that) when the tag is selected, but so far "Cursor Offset" sufficed me and if it was in hexadecimal, it would kinda show one value twice then. When a tag is clicked, the cursor is set to the first block of it, which is the more interesting value anyways.

Ah but looks like there is a bug with selection. When something is selected and then tags are clicked, Cursor Offset is changed but the values to the right of it aren't.

EUA commented 1 year ago

Will standardize those sections and they will show blocks in hex also, if current mode is hex.(or octal...)

Yup. Tag selection changes cursor offset and it changes. But tag clicking does not alter the selection. Since selection doesn't changed, Isn't that natural?

schrmh commented 1 year ago

This is the problem I meant: Fensterfoto_2023-10-22_20-47-54_Wxhexeditor At minimum "Cursor Value" is misleading in that case. (maybe two | would also be a bit helpful to visually separate a bit more between page, cursor and block values?)

EUA commented 1 year ago

Please use trunk and you will saw cursor value is updated when your select a tag. :)