EUDAT-B2HANDLE / PYHANDLE

Python library for HANDLE system
https://EUDAT-B2HANDLE.github.io/PYHANDLE/
Apache License 2.0
8 stars 13 forks source link

python_requires in setup.py not PEP440 compliant #88

Closed dtroelofsprins closed 4 days ago

dtroelofsprins commented 1 year ago

Dear pyhandle developers,

I encounter issues with the Python requirements in the setup.py python_requires='>=3.6.*<3.11' when running pipenv install. The requirement is included in the Pipfile.lock, but not correctly and subsequently pyhandle is not installed due to: Ignoring pyhandle: markers 'python_version >= "3.6.*<3.11"' don't match your environment whereas I'm using Python 3.10.8. This requirement turns out to be not PEP440 compliant as it should be according to the description.

I think it should become something like this: python_requires='>=3.6, <3.11'

themiszamani commented 1 year ago

Thank you for your notice. We will check and update !

themiszamani commented 1 year ago

Dear dtroelofsprins

We just uploaded a new version to pypi. Could you please check?

Kind regards

aquatix commented 1 year ago

With the current version on pypi, I get this on Python 3.11:

error in pyhandle setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.6.*<3.11'

For some reason it works fine on 3.10

themiszamani commented 1 year ago

Dear @aquatix

The answer is correct . It is for python <3.11 Working on new versions > 3.11

aquatix commented 1 year ago

Any news? There's no major changes between the already supported Python 3.10 and the newer 3.11, so I wonder what fixes are needed.

Can we help?

dtroelofsprins commented 4 days ago

Dear dtroelofsprins

We just uploaded a new version to pypi. Could you please check?

Kind regards

Sorry for my late response, up till now I didn't need to rebuild my Pipfile.lock, so never thought of it again. But with these changes things work fine now! Many thanks!