search

EUDAT-B2SHARE / b2share

B2SHARE software for the EUDAT CDI services.
https://b2share.eudat.eu
GNU General Public License v2.0
35 stars 32 forks source link

Community extension for BBMRI #150

Closed noumar closed 10 years ago

stranak commented 10 years ago

@noumar, please add the details from the email and the attached doc here. BBMRI guys might want to check the issue, add details, etc. Thanks.

teemukemppainen commented 10 years ago

There was discussion about the fields: Study design, Categories of data collected, sex and Material type - according to the specs they all work the same way, if the value(s) is(are) other than some of the predefined values, you can enter any other value as freetext.

teemukemppainen commented 10 years ago

I now have first comments from the BBMRI people, they are quite positive with some development ideas. Pavel, Mikael and I should discuss and agree what to do with these. I just post them here for everyone to see.

"It looks really good! We have tested a little bit and have some suggestions. We understand that it is under development but it could help to have some inputs"

  1. Certificate for https to avoid security warning from browser
  2. The list controls should allow multiple values
  3. The list fields should only allow predefined values from the lists. Probably it’s good to display the dropdown list when the control gets the focus (now you have to start typing for the list to display. Problem is if you start typing with a letter that does not appear in any of the values from the list, the list will not appear).
  4. Download files are only displayed in the same windows but not downloaded (-the same for export function)
  5. Edit: There should be an Edit function for uploaded files so the logged in user can modify the metadata or files ( add “My uploaded files” or so e.g. under “Your account”…)
  6. Are you planning to provide some functionality for the PID (there is a link there)
  7. Maybe consider changing the term “Deposit” to “Upload”..?
  8. What does “collections” refer to in the following phrase “The record appears in these collections:”? Consider rephrasing to domain if that is what you mean or define collection.
  9. Suggest moving Checksum field further down. Not so relevant for users to have it on top.
  10. The icon for Biomedical Research domain is too small. It would be possible to have just the icon? We can send the image (Comment: Teemu asked already them to send a new icon)
stranak commented 10 years ago

Certificate for https to avoid security warning from browser

:ok: That is just the test server. The real service has a correct certificate.

The list controls should allow multiple values

:ok: See Issue #204.

The list fields should only allow predefined values from the lists. Probably it’s good to display the dropdown list when the control gets the focus (now you have to start typing for the list to display. Problem is if you start typing with a letter that does not appear in any of the values from the list, the list will not appear).

:+1: See #205. We will probably use simple listboxes for sets of a few possible values and only for big sets try to combine them with autosuggest.

Download files are only displayed in the same windows but not downloaded (-the same for export function)

I see the problem, e.g. https://test-eudatis.csc.fi/record/131 The sloution we are going for:

Edit: There should be an Edit function for uploaded files so the logged in user can modify the metadata or files ( add “My uploaded files” or so e.g. under “Your account”…)

  • Provisionall sollution for metadata: add /edit to the record in question and you can edit metadata (provided it was submitted by you). It is not great and we will make a better edit interface.

Are you planning to provide some functionality for the PID (there is a link there)

It is working in the production repository. We disable it in the testing repository, because we don't want to create PIDs to temporary testing records.

Maybe consider changing the term “Deposit” to “Upload”..?

Possibly a good idea. Deposit is a bit "repository community" terminology.

What does “collections” refer to in the following phrase “The record appears in these collections:”? Consider rephrasing to domain if that is what you mean or define collection.

The "collections" functionality is not yet quite fixed. So far they correspond to "domains", but it may change. However we should do something about it, yes.

Suggest moving Checksum field further down. Not so relevant for users to have it on top.

Good idea: #206

The icon for Biomedical Research domain is too small. It would be possible to have just the icon? We can send the image (Comment: Teemu asked already them to send a new icon)

:ok: Please upload the new icon to the issue #207.

emanueldima commented 10 years ago

A first version of the extension is already upstream, but collections.sql and invenio-local.conf files still need to be updated

llehtine commented 10 years ago

I've updated the collections.sql and invenio-local.conf. Also the BBMRI should now be available in production. Can we close this issue? As the points pointed out by Teemu have separate issues open.

emanueldima commented 10 years ago

Yes, I've merged the changes in invenio-scripts

noumar commented 10 years ago

Question about "Disease" field vocabulary can be found in #258.