search

EUDAT-B2SHARE / b2share

B2SHARE software for the EUDAT CDI services.
https://b2share.eudat.eu
GNU General Public License v2.0
35 stars 32 forks source link

Fix OAuth2 special char issue and update B2ACCESS test server address #1869

Closed JohannesLares closed 2 years ago

JohannesLares commented 2 years ago

B2SHARE's B2ACCESS OAuth2 implementation don't support %-sign in client secret. The problem is b2access_basic_auth variable, where client secret has not been encoded properly. Added urllib.parse.quote function to encode client secret.

Added Content-Type header for good practice. The header can also be found in flask-oauthlib/client.py line 666. B2SHARE implementation overrides these functionalities and thus the header is not automatically added.

B2ACCESS test server has been changed to integration B2ACCESS server due to removal of old test server. Changed server address to B2SHARE config.py file.

closes #1868 , closes #1867

hjhsalo commented 2 years ago

LGTM. I will merge this.

hjhsalo commented 2 years ago

Please rebase on top of latest master