Fixes to directory listings

vladimir-mencl-eresearch commented 9 years ago

Hi Roberto,

I've done a bit more work on how this module does directory listings.

We use multiple replicas in our iRODS server - and the module was returning multiple entries for the same object - one for each replica.

I've applied the same fix as what Jargon does in CollectionAndDataObjectListAndSearchAOImpl.buildDataObjectListingWithAccessInfoFromResultSet : remember the last name seen, and only process the entry as a new file if it is different from the last name seen.
I've made the listings for directories/collections show the correct timestamp (extract from the information returned by iRODS).
I've added "." and ".." entries into the directory listings (for all but / folder) - details in the commit message.
I've noticed iRODS_l_dev_wrapper was incremented only when getting a value for a directory but not for a file. Assuming this was an oversight, changing the code to always increment the value...

Please let me know whether you're happy to merge these changes.

Cheers, Vlad

muccix commented 9 years ago

Hey Vlad,

thank you very much! I will test your fixes in the next days and merge the code!

Best, Roberto

vladimir-mencl-eresearch commented 9 years ago

Hi Roberto,

Happy to contribute!

FYI, looks like you missed the formatting in the release notes at https://github.com/EUDAT-B2STAGE/B2STAGE-GridFTP/releases/tag/release-1.6.5 and the text in angular brackets had disappeared - i.e., /<zone>/home/<username> is renedred as just //home/ (you should still be able to just edit the text of the release notes ...)

Cheers, Vlad

muccix commented 9 years ago

You are right!

Thanks again!

Cheers, Roberto

Il giorno Mon Feb 09 2015 at 10:29:08 PM Vladimir Mencl < notifications@github.com> ha scritto:

Hi Roberto,

Happy to contribute!

FYI, looks like you missed the formatting in the release notes at https://github.com/EUDAT-B2STAGE/B2STAGE-GridFTP/releases/tag/release-1.6.5 and the text in angular brackets had disappeared - i.e., //home/ is renedred as just //home/ (you should still be able to just edit the text of the release notes ...)

Cheers, Vlad

— Reply to this email directly or view it on GitHub https://github.com/EUDAT-B2STAGE/B2STAGE-GridFTP/pull/4#issuecomment-73593987 .

EUDAT-B2STAGE / B2STAGE-GridFTP

Fixes to directory listings #4