Relax assumption of hourly data

EUREC4A-UK / lagtraj

Python trajectory code for Lagrangian simulations

MIT License

9 stars 9 forks source link

Relax assumption of hourly data #95

Open leifdenby opened 3 years ago

leifdenby commented 3 years ago

Creating trajectories:

Add metadata to NetCDF output
Improve linear trajectory to work with haversine functions and actual velocities
Relax assumption of hourly data?

sjboeing commented 3 years ago

I think relaxing the assumption of hourly data may be the trickiest of these to test well. The rest could certainly be part of a first tagged version.

sjboeing commented 3 years ago

It looks like we are already using the haversine function in: extrapolate_posn_with_fixed_velocity

leifdenby commented 3 years ago

ok, so I'll make an issue to track the idea of making the improvement to "relax assumption of hourly data"? I don't quite understand what that actually means. We compute the time increments explicitly, so we should be able to support input with different time resolution already, no? Or is this referring to be able to interpolate in time?

sjboeing commented 3 years ago

I agree that as long as time increments are explicit everywhere, there should not be a problem in changing the input time resolution. We would need to check if there aren't any explicit references to the hourly character of the data Maybe we can test this by using 3-hourly input data? I would leave any time interpolation to beyond v0.1.0.

sjboeing commented 3 years ago

@leifdenby: changing the title as I think the other points (including NetCDF metadata) have now been addressed.