Submitters API keyID is being leaked

Tharre commented 9 years ago

The API returns "keyID", presumably the CCP API keyID from the submitter, for NPC-only kills.

Example: https://beta.eve-kill.net/api/kills/killID/46581118/no-items/

"zkb": {
    "involved": 1,
    "totalValue": 950453000.36,
    "points": 900,
    "source": "keyID:2951385"
 }

This has most likely been introduced with 7e9e9f4, however it seems to me that this is caused by an error in the database that has existed before. But that's hard to tell without the database at hand.

karbowiak commented 9 years ago

Hahaha, I knew I missed something! I'll fix it tomorrow!

That said, it doesn't really do anything, since the key id is meaningless without the vcode.. So, meh..

But I'll fix it! :)

lør. 23. maj 2015 02.48 skrev Tharre notifications@github.com:

The API returns "keyID", presumably the CCP API keyID from the submitter, for NPC-only kills.

Example: https://beta.eve-kill.net/api/kills/killID/46581118/no-items/

"zkb": { "involved": 1, "totalValue": 950453000.36, "points": 900, "source": "keyID:2951385" }

This has most likely been introduced with 7e9e9f4 https://github.com/EVE-KILL/zKillboard/commit/7e9e9f4aaeda02aa43a88b04d53a020b1444d019, however it seems to me that this is an error in the database that has existed before. But that's hard to tell without the database at hand.

— Reply to this email directly or view it on GitHub https://github.com/EVE-KILL/zKillboard/issues/319.

Tharre commented 9 years ago

Yeah, I tried getting the vCode as well but I failed ;)

EVE-KILL / zKillboard

Submitters API keyID is being leaked #319