Closed GoogleCodeExporter closed 9 years ago
Original comment by kovellia
on 29 May 2010 at 2:44
Two possible extensions to this. If a class is named Foo_Bar then the file
class.foo.php is checked. This way a collection of related classes can be in
the one
file. Another possibility is Foo_Bar looks in foo/class.bar.php.
I only see the first as a plus if the classes are related so that if one is
loaded
then the rest are also needed. Currently this is only true of the contract
classes.
Both toplist and eveapi files load a lot of unused classes.
The second approach could make the classes more manageable yet individually
small.
I may add this as a check for both possibilities for short term simplicity. A
call to
load Class http_request would first look in
common/includes/http/class.request.php
then if not found common/includes/class.http_request.php
Original comment by kovellia
on 30 May 2010 at 7:32
Continuing to discuss this with myself, I implemented the second option and
have
modified class.eveapi.php to match. A bit more testing is needed before I
submit it.
API_Killlog is mapped to api/class.killlog.php
Original comment by kovellia
on 30 May 2010 at 11:36
Changes all made and the ensuing dramas from changing filenames have been
quelled
Original comment by kovellia
on 3 Jun 2010 at 6:37
Original issue reported on code.google.com by
kovellia
on 29 May 2010 at 9:29