search

EVE-SECURE / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
0 stars 0 forks source link

Inconsistent totals on a Kill Detail page #91

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. View a kill
2. Notice totals do not match

What is the expected output? What do you see instead?
http://www.eve-primary.com/edk3/index.php?a=kill_detail&kll_id=20602
Total at top is: 930,936,000
Total at bottom: 929,155,293.00

What version of the product are you using? On what operating system?
EDK 3.0.1 with all updates applied

Original issue reported on code.google.com by cvwe...@gmail.com on 23 Feb 2010 at 8:24

GoogleCodeExporter commented 9 years ago 
I can reproduce this error. Not immediately seeing a cause but the neat 
rounding is 
probably related.

Original comment by kovellia on 28 Feb 2010 at 8:54

GoogleCodeExporter commented 9 years ago 
Today the off value is at 935,647,612.00!

Looking into the issue, the 930,936,000 is stored in kb3_kills and the 2nd 
value is
calculated on the fly.  The "on the fly" calculation is a sum of dropped, 
destroyed,
and ship total values.  The final sum calculation can be found on line 722 of
common/kill_detail.php  (3.0.1 (Dominion) rev 529)

My guess is that the 930m stored in the DB is the value of the kill on the day 
of the
kill, and the 935m is the value of the kill today.  Shouldn't all values stay
consistent to the day of the kill?

Original comment by cvwe...@gmail.com on 2 Mar 2010 at 4:25

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Ah, of course. That will be the problem. The two should either be consistent or
specify that one price is using current values. (Or go back to an alternative 
from a
while ago and store the value of every item on the mail at the time of the 
kill.)

Original comment by kovellia on 2 Mar 2010 at 10:30

GoogleCodeExporter commented 9 years ago 
Fixed in r556. Prices are now labelled as current values or value at time of 
kill.

Original comment by kovellia on 3 Mar 2010 at 9:56