kill->getInvolved in class.kill.php

[GoogleCodeExporter]

What is the enhancement you would like to see?

A new method added to the Kill class to expose the involvedparties_
variable in a reliable way.

What steps would use of your enhancement involve?
1. Add the following code to class.kill.php:-

function getInvolved(){
$this->execQuery();
return $this->involvedparties_;
}

or something similar.

Please provide any additional information below.

This would be useful in a couple of mods I have in development and would
probably neaten the generation of the kill summary page.

Original issue reported on code.google.com by vascowhite on 24 Feb 2010 at 9:54

[GoogleCodeExporter]

Good idea. I want to redo the whole Kill class interface and return, say, a 
Pilot 
object instead of duplicating all the Pilot methods.

Adding the (easy) useful methods that don't break all the other code is a good 
place 
to start.

I may change your suggestion to function getInvolved($detailed =  false) so you 
can 
choose between the detailed list of involved or the standard.

Original comment by kovellia on 25 Feb 2010 at 12:06

• Changed state: Accepted
• Added labels: Priority-Low, Type-Enhancement
• Removed labels: ****

[GoogleCodeExporter]

Thanks for the feedback. Your suggested change sounds like the right way to go.

Original comment by vascowhite on 25 Feb 2010 at 9:37

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Actually, my suggested change had a floor. You have to specify that you want 
the 
detailed involved before the query is executed, and you can't know in advance 
of 
calling getInvolved() if it has been executed. So I'm just adding the method as 
you 
first suggested.

Original comment by kovellia on 25 Feb 2010 at 11:05

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Added in r551.

Original comment by kovellia on 25 Feb 2010 at 8:49

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****