search

EVE-SECURE / joomla-in-eve

Automatically exported from code.google.com/p/joomla-in-eve
0 stars 0 forks source link

Image Server being referenced #34

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. On Character sheet there is no image displayed
2.
3.

What is the expected output? What do you see instead?
The character portrait should be seen

Can you provide path and query segment URL of faulty page?
example: /index.php?option=com_eve&view=character&characterID=111111111:Cha
racter&Itemid=1 or
/alliance/c/222222222-Corporation/c/111111111-Character.html

Ho the site is private..

What version of the product are you using? Please provide version of core 
component (com_eve) and faulty component (com_...).

com_eve-0.6.256

Please provide any additional information below. Try turn on joomla debug
mode.

Looking at the url it is referencing 
http://img.eve.is/serv.asp?s=256&c=1686217288

In a browser this url generates a 404 as it appears this server no longer 
exists.

In the character display the image is referenced using 
http://image.eveonline.com/Character/1686217288_128.jpg" alt="Ravenhood" and 
this displays normally.

Where do I modify the incorrect server reference for img.eve.is/serv.asp 

At the same time I am getting:
Warning: Invalid argument supplied for foreach() in 
/data/www/vhosts/dkb-uk.net/httpdocs/components/com_evecharsheet/models/characte
r.php on line 181 

I think this is because of the faulty reference to the image display but please 
confirm..

Thank you for your assistance.

Original issue reported on code.google.com by keilsont...@gmail.com on 27 Jan 2011 at 12:12

GoogleCodeExporter commented 9 years ago 
I sorted both issues listed here.

In file 
components/com_evecharsheet/views/character/tmpl/default.php
around line 22
I changed 
<img src="http://img.eve.is/serv.asp?s=<?php echo 
$this->params->get('portraitsize', 256); ?>&c=<?php echo 
$this->character->characterID; ?>" /> <br />
to 
<img src="http://image.eveonline.com/Character/<?php echo 
$this->character->characterID; ?>_64.jpg" /> <br />

Additionally I modified file
components/com_evecharsheet/models/character.php
around line 181 - simply commented out this section

/**     foreach ($learningSkills->skills as $learningSkill) {
            if ($learningSkill->typeID == $this->learningTypeID) {
                $skillMultiplier = 1.0 + $learningSkill->level / 50;
            } else {
                $attributeID = JArrayHelper::getValue($this->skillToAttributes, $learningSkill->typeID);
                $attribute = JArrayHelper::getValue($attributes, $attributeID);
                if ($attribute) {
                    $attribute->skillValue += $learningSkill->level;
                }
            }
        }
*/

It has cleared the issues but undoubtedly there is a better solution.

Original comment by keilsont...@gmail.com on 27 Jan 2011 at 2:53

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
on line 25 in the file 
\com_evecharsheet-0.6.256\site\views\user\tmpl\default.php 
instead of using
<?php echo JHTML::_('image', 
'http://img.eve.is/serv.asp?s=64&c='.$character->characterID, 
$character->name); ?>

use

<img src="http://image.eveonline.com/Character/<?php echo 
$character->characterID ?>_128.jpg" /> 

(instead of 128 it's possible set 64)

Original comment by marcomis...@googlemail.com on 23 May 2011 at 3:27

GoogleCodeExporter commented 9 years ago 
fixed in r267 and r268

Original comment by koval...@gmail.com on 25 May 2011 at 2:46