search

EVE-University / whctools

WHC app for joining
MIT License
1 stars 1 forks source link

Leaving with a main while alts are applied does not remove the alt applications #44

Open mome-borogove opened 3 months ago

mome-borogove commented 3 months ago

Repro:

  1. Apply with main, accept
  2. Apply with alts
  3. Leave with main
  4. Check staff pending applications page, alts are still pending, no indication main left

Since it's disallowed to apply an alt without a main, the solution here is probably to auto-reject the alt applications with the leave/withdraw cooldown.

Note that this is a bit at odds with the behavior of what happens if you accept those alts first (since they don't get kicked currently), but that's mostly (again) due to the auth main/whc main issue since we have no notion of swapping whc mains, so if a character drops corp, the auth main is auto-updated and whctools is left with a weird state.

In fact, now I'm kind of curious what happens to the ACL view when an auth main is changed....

lynkfox commented 3 months ago

The auth main changed : should just shift the chars around. When the page is built it checks which char is registered as main, and sorts the other chars under it

On Tue, Jul 23, 2024, 9:41 PM mome-borogove @.***> wrote:

Repro:

  1. Apply with main, accept
  2. Apply with alts
  3. Leave with main
  4. Check staff pending applications page, alts are still pending, no indication main left

Since it's disallowed to apply an alt without a main, the solution here is probably to auto-reject the alt applications with the leave/withdraw cooldown.

Note that this is a bit at odds with the behavior of what happens if you accept those alts first (since they don't get kicked currently), but that's mostly (again) due to the auth main/whc main issue since we have no notion of swapping whc mains, so if a character drops corp, the auth main is auto-updated and whctools is left with a weird state.

In fact, now I'm kind of curious what happens to the ACL view when an auth main is changed....

— Reply to this email directly, view it on GitHub https://github.com/EVE-University/whctools/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLOBQ72TB2EJ2MHIVHM5TDZN4A4NAVCNFSM6AAAAABLLPZQVSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMNBRGQZDOMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mome-borogove commented 3 months ago

Gotcha. I was concerned it was a map with mains as keys, but I see that is reconstructed dynamically every time, so it's not an issue.

Thanks.