EVGENIAST / cumulusrdf

Automatically exported from code.google.com/p/cumulusrdf
0 stars 0 forks source link

Build errors in branch 1.0.1 #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. svn co https://cumulusrdf.googlecode.com/svn/branches/1.0.1 cumulusRDF
2. cd cumulusRDF
3. mvn clean install

Expected output is a build success but instead a build failure is reported.
Specifically, there are two problems

1) cannot find symbol LRUMap

LRUMap (used for example in NodeDictionaryBase) comes from sesame-sail-rdbms. 
Now, I'm not able to build the project using maven because that jar is 
(indirectly) declared with "runtime" scope.

That means  

- in an Eclipse workspace all works fine (no compilation errors) because m2e 
imports runtime jars (actually it makes no distinction between scopes) in build 
path;
- running a m2e or a Maven build will fail because that dependency is not found 
at compile time. 

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
...
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) 
on project cumulusrdf: Compilation failure: Compilation failure:
[ERROR] 
/home/agazzarini/workspaces/cumulusRDF/cumulusrdf/src/main/java/edu/kit/aifb/cum
ulus/store/dict/NodeDictionaryBase.java:[13,34] package 
org.openrdf.sail.rdbms.util does not exist
[ERROR] 
/home/agazzarini/workspaces/cumulusRDF/cumulusrdf/src/main/java/edu/kit/aifb/cum
ulus/store/dict/NodeDictionaryBase.java:[47,9] cannot find symbol
...
[ERROR] 
/home/agazzarini/workspaces/cumulusRDF/cumulusrdf/src/main/java/edu/kit/aifb/cum
ulus/util/hector/CassandraHectorMap.java:[29,34] package 
org.openrdf.sail.rdbms.util does not exist
[ERROR] 
/home/agazzarini/workspaces/cumulusRDF/cumulusrdf/src/main/java/edu/kit/aifb/cum
ulus/util/hector/CassandraHectorMap.java:[118,9] cannot find symbol
[ERROR] symbol  : class LRUMap
[ERROR] location: class edu.kit.aifb.cumulus.util.hector.CassandraHectorMap<K,V>

2) RestServletPojoTest

This class, which is in the test/src folder, is referenced in a @See comment, 
in RestApplicationResource (line 483) which belongs to main/src folder. 
As consquence of that, RestApplicationResource imports a class which belongs to 
tests which are not visible during the build. 

That is not immediately visible on IDE (i.e. Eclipse) where there are no 
compilation errors but running a m2e or a Maven build I get

[ERROR] 
/home/agazzarini/workspaces/cumulusRDF/cumulusrdf/src/main/java/edu/kit/aifb/cum
ulus/webapp/rest/RESTApplicationResource.java:[44,34] cannot find symbol
[ERROR] symbol  : class RestServletPojoTest
[ERROR] location: package edu.kit.aifb.cumulus.webapp

Original issue reported on code.google.com by a.gazzarini@gmail.com on 23 Jan 2014 at 10:31

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r752.

Original comment by a.gazzarini@gmail.com on 23 Jan 2014 at 11:54

GoogleCodeExporter commented 8 years ago
- sesame-sail-rdbms has been declared with default scope (compile): not sure if 
this is the best LRUMap impl and if we want to import that whole library for 
one class

- removed @See Javadoc comment in RestApplicationResource 

Original comment by a.gazzarini@gmail.com on 23 Jan 2014 at 11:57

GoogleCodeExporter commented 8 years ago
Hi Andrea,

thanks for fixing this ;) I didn't check the new branch for build errors 
before. Sorry about that.

Regarding your the "sesame-sail-rdbms" dependency: I agree - its not needed at 
all. We can use any LRUMap implementation. In general, the sesame dependency 
management is not good. We simply have 

<groupId>org.openrdf.sesame</groupId>
<artifactId>sesame-runtime</artifactId>

in our current pom. This simply adds (almost) all sesame libs. Regardless if 
they are needed. I added this as issue 23. I will look at this ...

Kind regards
Andreas

Original comment by andreas.josef.wagner on 24 Jan 2014 at 8:26