search

EVNotify / EVNotifyPWA

PWA Webinterface for EVNotify
7 stars 3 forks source link

More space top to bottom on dashboard. Changed some naming and.. #49

Closed Pazekal90 closed 5 years ago

Pazekal90 commented 5 years ago

... get a little more space between subheaders and the content for an easier view on dashboard.

Before:

Bildschirmfoto 2019-07-27 um 13 46 50

After:

Bildschirmfoto 2019-07-27 um 13 47 37
GPlay97 commented 5 years ago

Somehow now the bottom is messed up. Previously there was full page height forced. This was removed (by you?) somehow. Please add this again, otherwise this looks bad (you see the border at the end, if space left)

Pazekal90 commented 5 years ago

@GPlay97 Changed the background thing. Was an earlier commit in one of my last pull requests

GPlay97 commented 5 years ago

image

Thanks. But the dashboard is no longer centered since your changes. Can you fix this? In logs for example it is correct.

Pazekal90 commented 5 years ago

@GPlay97 Ok done. But this was a problem with layout containers. I have earlier cleaned up some css manipulations that are not recommended by vuejs and now this problem has been visible. So I have now fixed this for all later components.

Pazekal90 commented 5 years ago

sorry there's another error. I'm on it

Pazekal90 commented 5 years ago

Was a cache thing. Ready for your review.

Pazekal90 commented 5 years ago

Problem is this notation here.

Bildschirmfoto 2019-07-28 um 14 32 52

If this PR is merged i will create another one to handle better the "justify to center" situation in here. There shouldn't be a offset for sm viewports. Instead there should be a justify-center attribute for the v-layout container. Then the chart in log details would also be better visible in landscape mode.