search

EVNotify / EVNotifyPWA

PWA Webinterface for EVNotify
7 stars 3 forks source link

Remove google maps, use OpenStreetMap instead #88

Open yankee42 opened 3 years ago

yankee42 commented 3 years ago

In the triplog and also on the dashboard for last known position the map is not directly shown. There is a "why?" link which says:

[..]displaying the map costs also real money for me as a developer.[..]

That's strange... OpenStreetMap is free and... at least in my opinion also clearly superior to Google Maps. You can't find that this bad, because in the Android-App it is already OpenStreetMap. Why not use it on the Web UI as well?

Here is a PR to replace Google Maps with OSM. It's work in progress however. I have a problem with the Map not initially drawing. As soon as I resize the browser window a tiny bit, the map comes up fine. Why? I have never worked with vue, so in case it has to do with something that Vue does I wouldn't know. (For that matter, the last time I coded plain JavaScript or used OpenLayers is many years ago...). So maybe another pair of eyes can see what I cannot see?

BTW: A little confusing: Some files are indented with 4 spaces, others with 2 spaces. I didn't really know what to do...

I also added some typedefs for the Log. I get totally lost without automatic code completion ;-). However some values seem to be always null for me. Maybe you got some improvements there.