search

EVerest / cbexigen

cbExiGen - The V2GTP EXI codec generator for cbV2G
Apache License 2.0
32 stars 18 forks source link

ParameterSet count too low #72

Closed TGruett closed 5 months ago

TGruett commented 7 months ago

Describe the bug

Hi,

In PR 32, the limit for ParameterSets was set to 5. As has been shown, this limit is somewhat too low in practice. As long as the loop implementation for large arrays is missing, i recommend to increase this value.

To Reproduce

Encode/Decode ServiceDetailRes with 6 or more ParameterSets

Anything else?

Why is there even this limit for more than 25 occurs? Everything seems to work for me if i remove that limit

barsnick commented 7 months ago

We also noticed the same issue recently. By chance, our own products use a higher limit.

I agree with a size of 8, perhaps 16 is okay as well.