search

EVerest / everest-core

Apache License 2.0
99 stars 72 forks source link

Active errors are not cleared in API module #797

Closed marco-mariotto closed 1 month ago

marco-mariotto commented 3 months ago

Describe the bug

In the API.cpp file when a non-permanent error gets cleared, shouldn't we have the following:

    case Event::ErrorCleared:
        remove_error_from_list(this->active_errors, error.type);
        break;

Currently it just falls back to case Event::PermanentFaultCleared

EVerest Domain

Other

Affected EVerest Module

API.cpp, function SessionInfo::update_state

To Reproduce

Version is tag 2024.6.0.

Anything else?

No response

Pietfried commented 1 month ago

The PermanentFaultCleared event has been removed from the evse_manager types and the API module now makes use of the error handling provided by the everest-framework