Update the ISO 15118-2 DC demo with -2 message logs

drmrd commented 8 months ago

This PR aligns the demo with what we've been showing during industry outreach events. Changes to the ISO 15118-2 DC demo's Node-Red flows result in all ISO 15118-2-related messages being displayed in a table. The actual request and response messages remain EXI-encoded. A V2G decoder (such as this one based on RISE-V2G) can then be used to decode these messages.

Future improvements could include incorporating a Node-based V2G decoder into the dashboard or to log un-encoded V2G messages more directly. The message types that are published during the demo's 15118-2 request-response message sequence(s) are displayed above the table in real-time, as well.

shankari commented 8 months ago

@drmrd are you sure that this works as checked in? I tried testing it and I wasn't able to launch the node-red server or the UI

Logs from the launch

Checking out this branch

$ git checkout --track origin/add-15118-dash-2-logs-to-dc-demo

Launching the docker compose

$ docker compose -f docker-compose.iso15118-dc.yml up
[+] Building 0.0s (0/0)                                                             docker:desktop-linux
[+] Running 3/0
 ✔ Container everest-demo-mqtt-server-1  Created                                                    0.0s
 ✔ Container everest-demo-node-red-1     Created                                                    0.0s
 ✔ Container everest-demo-manager-1      Created                                                    0.0s
Attaching to everest-demo-manager-1, everest-demo-mqtt-server-1, everest-demo-node-red-1

Everest has started up

everest-demo-manager-1      | 2023-11-21 05:49:34.890996 [INFO] manager          :: 🚙🚙🚙 All modules are initialized. EVerest up and running [2087ms] 🚙🚙🚙
everest-demo-manager-1      | 2023-11-21 05:49:37.582542 [INFO] evse_manager:Ev  :: 🌀🌀🌀 Ready to start charging 🌀🌀🌀

But we get MQTT errrors while trying to connect node-red

everest-demo-mqtt-server-1  | 1700545789: New connection from 192.168.65.1:38789 on port 1883.
everest-demo-mqtt-server-1  | 1700545789: Client <unknown> disconnected due to protocol error.
everest-demo-mqtt-server-1  | 1700545789: New connection from 192.168.65.1:38790 on port 1883.
everest-demo-mqtt-server-1  | 1700545789: Client <unknown> disconnected due to protocol error.
everest-demo-mqtt-server-1  | 1700545789: New connection from 192.168.65.1:38791 on port 1883.
everest-demo-mqtt-server-1  | 1700545789: Client <unknown> disconnected due to protocol error.

couryrr-afs commented 8 months ago

@shankari I think you have a typo in the browser. You will want to access localhost:1880/ui to access the node-red ui.

shankari commented 8 months ago

Ooops! This is why I shouldn't test at 10pm.

This does launch now, but it doesn't include the new logging functionality, since the image has not been updated. Since this is a common theme, and @drmrd is out, I have created a new branch (build_pkg_task_1_features) - you can push all these changes to that branch as well to build an image that includes them, and then update all these PRs to use the image tag.

couryrr-afs commented 8 months ago

@shankari if I am reading this correctly the creation of images looks to be postponed until the PR is merged. This is so that there is not functionality within the running container that relies on the code in the PR. To test a PR's changes locally you can build that image yourself when pulling down the code. I am leaning toward adding a latest tag to the workflow that would pin the latest PR that is merged. Then in all of the docker-compose.yml we can just reference :latest for now. Then we do not need to go through an extra branch.

shankari commented 8 months ago

@couryrr-afs as you can see from the action and the issue, the current flow is:

you push to 'build_pkg_**' (either through PR or direct push) currently in the US-JOET org
images are built and uploaded automatically to the US-JOET org
you change the docker-compose to use the new image and re-push the PR

Yes, this is clunky. We should fix it even in the short term

drmrd commented 8 months ago

Closing this PR in favor of US-JOET/everest-demo#3 to accommodate existing Docker build process.

drmrd commented 8 months ago

Re-opening for the time being, with the intent being to finish a review after we update the CI in #10.

shankari commented 7 months ago

@drmrd if you can resolve the merge conflict and bump up the version, this one has been approved and is good to go.

drmrd commented 7 months ago

@shankari: I believe this PR is updated and ready to go.

EVerest / everest-demo

Update the ISO 15118-2 DC demo with -2 message logs #3

Logs from the launch